Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
According to the php 7 migration manual (http://php.net/manual/en/migration70.incompatible.php), some names can't be used as class names anymore since php 7:
The following names cannot be used to name classes, interfaces or traits:
- bool
- int
- float
- string
- NULL
- TRUE
- FALSE
We currently have a String Data type and that fails on php7, the facet api travis tests have discovered this: https://travis-ci.org/nickveenhof/facetapi/jobs/87654550.
This patch adds DataType to all the data types.
Comment | File | Size | Author |
---|---|---|---|
#5 | data_types_are_php_7-2602458-5.patch | 4.83 KB | borisson_ |
| |||
#5 | interdiff.txt | 3.26 KB | borisson_ |
Comments
Comment #2
borisson_Comment #3
borisson_Comment #4
drunken monkeyAh, darn, you're right of course! Seems we all forgot about that …
A bit more motivation to tackle #2552453: Fix test fails on Postgres, SQLite and PHP 7 sooner rather than later, I guess.
I don't think that's necessary, though? I would like to avoid that change, if possible.
Comment #5
borisson_Comment #6
drunken monkeyLooks good now, thanks again!
Committed.