I've used the module with PNG and JPEG optimizers, but they do not apply to GIF files.
So is it an option to include one more tab in the bottom that will group tools for optimizing GIfs like:
- http://www.lcdf.org/gifsicle/ - one that I found after a fast google search.
- Others.

As far as I know we should just implement a plugin for each of the processors, so it should not be that huge of a task.

CommentFileSizeAuthor
#12 imageapi_optimize_binaries-add_support_for_optimizing_gif-2602398-12.patch2.9 KBSylvainM
#11 imageapi_optimize_binaries-add_support_for_optimizing_gif-2602398-11.patch2.89 KBSylvainM
#8 imageapi_optimize-add_support_for_optimizing_gif-2602398-8.patch2.88 KBSylvainM
#6 imageapi_optimize-add_support_for_optimizing_gif-2602398-5.patch0 bytesSylvainM
#5 imageapi_optimize-add_support_for_optimizing_gif-2602398-5.patch0 bytesSylvainM
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ndobromirov created an issue. See original summary.

tamnv’s picture

tamnv CreditAttribution: tamnv commented

Hi @ndobromirov,

JPG is a lossy compression. This means that you can use "quality parameter" to adjust size / quality ratio. GIF is a lossless compression, you cannot get better compression by adjusting quality. You can read more on php.net:
http://php.net/manual/en/function.imagepng.php
http://php.net/manual/en/function.imagejpeg.php
http://php.net/manual/en/function.imagegif.php

ndobromirov’s picture

ndobromirov CreditAttribution: ndobromirov at FFW commented

Hi,

I think you are misunderstanding the issue scope and this module's purpose.
Whenever the user uploads an image this module will try to improve it through a pre-defined list of processor tools.
All of them are not PHP based. Check the module's code for an example list and do a fast google search on it.

This issue is a feature request that will allow you to apply GIF optimizer tools, when the users are uploading them on the system.
I found 1 such tool stated in the description, but due to current work loads I am not able to implement the plugin wrappers for it and experiment.

This has nothing to do in relation to lossy/non-lossy formats, as even if PNGs are loose-less format (image files container), you can apply lossy compression on the image data through pngquat for example and still compress it more than the initial size. Usually compression with 10-20% quality loss results in 60-70% size reduction on PNGs.

BR,
Nikolay Dobromirov.

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Status: Active » Postponed (maintainer needs more info)

I'd welcome patches that implemented gif optimizers.

SylvainM’s picture

SylvainM CreditAttribution: SylvainM at Axess Open Web Services commented
Status: Postponed (maintainer needs more info) » Needs review
FileSize
imageapi_optimize-add_support_for_optimizing_gif-2602398-5.patch0 bytes

Please test this processor

SylvainM’s picture

SylvainM CreditAttribution: SylvainM at Axess Open Web Services commented
Version: 7.x-1.x-dev » 8.x-2.x-dev
FileSize
imageapi_optimize-add_support_for_optimizing_gif-2602398-5.patch0 bytes

oops

The last submitted patch, 5: imageapi_optimize-add_support_for_optimizing_gif-2602398-5.patch, failed testing. View results

SylvainM’s picture

SylvainM CreditAttribution: SylvainM at Axess Open Web Services commented
FileSize
imageapi_optimize-add_support_for_optimizing_gif-2602398-8.patch2.88 KB

ooops, again…

This one is not empty

The last submitted patch, 6: imageapi_optimize-add_support_for_optimizing_gif-2602398-5.patch, failed testing. View results

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Project: Image Optimize » Image Optimize Binaries
Version: 8.x-2.x-dev »
SylvainM’s picture

SylvainM CreditAttribution: SylvainM at Axess Open Web Services commented
Version: » 8.x-1.x-dev
FileSize
imageapi_optimize_binaries-add_support_for_optimizing_gif-2602398-11.patch2.89 KB

Here is a new patch for this new module

SylvainM’s picture

SylvainM CreditAttribution: SylvainM at Axess Open Web Services commented
FileSize
imageapi_optimize_binaries-add_support_for_optimizing_gif-2602398-12.patch2.9 KB

This patch is better…

vistree’s picture

vistree CreditAttribution: vistree commented

Hi, @SylvainM, should your patch form #12 still work? Do you expect animitad GIFs to be still animated after the precessor has been applied?

SylvainM’s picture

SylvainM CreditAttribution: SylvainM at Axess Open Web Services commented

> should your patch form #12 still work?
Yes, it works

> Do you expect animitad GIFs to be still animated after the precessor has been applied?
Yes

vistree’s picture

vistree CreditAttribution: vistree commented

Hi sylvainM,
Thanx for your reply. Gifs are not animated on my environment. I use standard gd2 being set to 100% in image toolkit. Should this work or do I have to change e.g. to imagemagick to make your processor work?

SylvainM’s picture

SylvainM CreditAttribution: SylvainM at Axess Open Web Services commented

GD2 can't keep animation in gif, you have to use imagemagick for your image styles

vistree’s picture

vistree CreditAttribution: vistree commented

Thanx @SylvainM. I will try out!!

vistree’s picture

vistree CreditAttribution: vistree commented

Maybe stupid question, but if I use ImageMagick - why do I need image optimize binrary?

SylvainM’s picture

SylvainM CreditAttribution: SylvainM at Axess Open Web Services commented

I think Image Magick can't do all those optimizations