Here is a summary of the discussion from

#2470661: Port "Flag a [entity type]" Rules action to 8.x

For plugins being added to the flag module - We need tests that extend \Drupal\Tests\rules\Integration\RulesEntityIntegrationTestBase

Those tests are best housed in the rules module.

Remaining Tasks:-

  1. Finish the flag issue. at which point the new Plugins will exist
  2. Move the tests in the rules module
  3. .Harmonize them using \Drupal\Tests\rules\Integration\Action\BanIPTest
    as a template.

Comments

martin107 created an issue. See original summary.

dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
CreditAttribution: dasjo commented

Hi,

I'm wondering, what's the reason why these tests should live in the rules module?

From my point of view tests should remain next to the functionality, in this case they should live in the flag module.

djevans’s picture

djevans CreditAttribution: djevans as a volunteer commented

There's an example of a Rules integration test in Flag here:

https://www.drupal.org/node/2540032#comment-11056785

TR’s picture

TR CreditAttribution: TR commented
Status: Postponed » Closed (won't fix)

The Rules module is the wrong place for Flag tests. #2540032: Port "Flag is flagged" Rules event to 8.x now contains Flag tests that depend on RulesEntityIntegrationTestBase and which work just fine on the testbot.