See original pull request @ https://github.com/pjbaert/calendar/commit/2d708849217019b13ffaa275a4bb7...
I'm copying my initial patch in here.

CommentFileSizeAuthor
#4 docblock_check-2600332-4.patch8.46 KBpjbaert
#4 interdiff_3-4.txt5.15 KBpjbaert
#3 docblock_check-2600332-3.patch4.51 KBpjbaert
docblock_check_1.patch3.76 KBpjbaert
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pjbaert created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at XIO commented
Status: Active » Needs work

Thanks for creating this!

My feedback was:

+++ b/css/calendar.css
@@ -100,7 +100,8 @@
+ * Make sure paragraphs buried in calendar cells use padding, not margins, for separation so the background color
+ * doesn't come through.

+++ b/css/calendar_multiday.css
@@ -89,7 +89,8 @@
+ * Make sure paragraphs buried in calendar cells use padding, not margins, for separation so the background color
+ * doesn't come through.

These lines are too long.

pjbaert’s picture

pjbaert
Primary language Dutch
CreditAttribution: pjbaert at XIO commented
Status: Needs work » Needs review
FileSize
docblock_check-2600332-3.patch4.51 KB

Rerolled the patch & processed the feedback from #2

pjbaert’s picture

pjbaert
Primary language Dutch
CreditAttribution: pjbaert at XIO commented
FileSize
interdiff_3-4.txt5.15 KB
docblock_check-2600332-4.patch8.46 KB

Updated my patch.

  • pjonckiere committed 0140c4a on 8.x-1.x authored by pjbaert 
    Issue #2600332 by pjbaert: Make sure docblock lines don't exceed 80...
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at XIO commented
Status: Needs review » Closed (fixed)

Pushed to 8.x-1.x. Thanks!

+++ b/calendar.theme.inc
@@ -800,7 +800,8 @@ function template_preprocess_calendar_stripe_legend(&$vars) {
+ *   Returns an array with the max depth of the branch and whether an overlap
+ *   occurred

Fixed this missing dot on commit.