[D7] Webform conditional extra

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandbox_KurT_2599682git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

http://pareview.sh/pareview/httpgitdrupalorgsandboxkurt2599682git

PFA, Pareview report has lot of errors in webform_extra.js file. Please first fix these issues.

Thanks.

project page at https://www.drupal.org/sandbox/_kurt_/2599682 is empty, could you describe your module according to https://www.drupal.org/node/997024 ?

Review of the 7.x-1.x branch (commit 642af26):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/README.txt
  ----------------------------------------------------------------------
  FOUND 1 ERROR AFFECTING 1 LINE
  ----------------------------------------------------------------------
   20 | ERROR | [x] Expected 1 newline at end of file; 0 found
  ----------------------------------------------------------------------
  PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
  ----------------------------------------------------------------------
  
  Time: 111ms; Memory: 7.5Mb
  

• ESLint has found some issues with your code (please check the JavaScript coding standards).
  

  /home/klausi/pareview_temp/js/webform_extra.js: line 7, col 3, Error - Strings must use singlequote. (quotes)
  
  1 problem
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

• webform_conditional_extra_form_select_number(): are you sure that you need to call drupal_render() here? Just adding the render array should work since it will bre rendered later automatically?

Otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to mpdonadio as he might have time to take a final look at this.

Automated Review

Review of the 7.x-1.x branch (commit 642af26):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /Users/matt/PAR/pareview_temp/README.txt
  ----------------------------------------------------------------------
  FOUND 1 ERROR AFFECTING 1 LINE
  ----------------------------------------------------------------------
   20 | ERROR | [x] Expected 1 newline at end of file; 0 found
  ----------------------------------------------------------------------
  PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
  ----------------------------------------------------------------------
  
  Time: 224ms; Memory: 6.5Mb
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Manual Review

Typo in description in .info file

I think you can just implement HOOK_form_webform_client_form_alter() to target webforms, instead of a generic form alter
and checking the ID.

Your JS has an empty .ready(). Remove this eventualy (and in Drupal it should be an attach behavior anyway).

Nothing jumped out at me to block this application.

Thanks for your contribution, _KurT_!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.