Problem/Motivation

Proposed resolution

Should still show the form.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 poll_vote_ajax_submit-2599120-4.patch2 KBedurenye
#4 poll_vote_ajax_submit-2599120-4-test_only.patch1.29 KBedurenye
#2 poll_vote_ajax_submit-2599120-2.patch723 bytesedurenye
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

edurenye’s picture

edurenye CreditAttribution: edurenye at MD Systems GmbH commented
Status: Active » Needs review
FileSize
poll_vote_ajax_submit-2599120-2.patch723 bytes

Done, now don't show the results if there is an error.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Issue tags: +needs test

Can we test this bug?

edurenye’s picture

edurenye CreditAttribution: edurenye at MD Systems GmbH commented
FileSize
poll_vote_ajax_submit-2599120-4-test_only.patch1.29 KB
poll_vote_ajax_submit-2599120-4.patch2 KB

Added tests.

The last submitted patch, 4: poll_vote_ajax_submit-2599120-4-test_only.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: poll_vote_ajax_submit-2599120-4.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Postponed

I'm reasonably sure that #2599124: All poll actions should use ajax, drop confirmation form for cancel will fix this. We just need test coverage then. Which is not yet possible, so postponing.

edurenye’s picture

edurenye CreditAttribution: edurenye at MD Systems GmbH commented
Status: Postponed » Needs work

This issue is fixed #2599124: All poll actions should use ajax, drop confirmation form for cancel, I'll check if this error still happens.

edurenye’s picture

edurenye CreditAttribution: edurenye at MD Systems GmbH commented

Checked, it doesn't happen any more, so I'll add test coverage.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Category: Bug report » Task
Priority: Major » Normal
Issue tags: -needs test +Needs tests

It's nice when things just work when done correctly ;)

Changing to a task then.

edurenye’s picture

edurenye CreditAttribution: edurenye at MD Systems GmbH commented
Status: Needs work » Needs review

We didn't check but seems that the tests that I added before are working fine, are in the comment 4.

  • Berdir committed c71a0a6 on 8.x-1.x authored by edurenye 
    Issue #2599120 by edurenye: Tests for Poll vote ajax submit shows...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed
Issue tags: -Needs tests

Interesting, I guess because the message replacement works, it's just the form replacement on success that doesn't.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.