Problem/Motivation

Returning to CredentialForm after a rollback gives the following error.

Undefined index: pgsql in Drupal\migrate_upgrade\Form\MigrateUpgradeForm->buildCredentialForm() (line 743 of modules/migrate_upgrade/src/Form/MigrateUpgradeForm.php).

To reproduce:

  1. Perform an upgrade. I'm using a small D6 test site.
  2. When complete, return to /upgrade. Select Rollback.
  3. Perform the rollback
  4. When complete, click continue.
CommentFileSizeAuthor
#4 2598900-4.patch1.87 KBquietone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented
Status: Active » Postponed (maintainer needs more info)

I can't reproduce this, with source DB and destination (DB) MySQL. What are your source and destination DB engines?

quietone’s picture

quietone CreditAttribution: quietone commented

Thanks for trying. Both source and destination are MySQL and I've never done anything with the engines, so I guess the defaults.

I tried to track down the problem and only discovered more bad things. Nodes are not migrated at all for two D6 sites and D7 site hangs on taxonomy. So, until I find out what that is all about this will have to wait.

Maybe now is a good time to spin up a fresh container and rebuild. ;-)

quietone’s picture

quietone CreditAttribution: quietone commented
Issue summary: View changes
FileSize
2598900-4.patch1.87 KB

Yes, this is still happening. I wonder what would happen if I also had PostGres installed. Anyway, the attached patch avoids the problem completely by only using the form advanced_options if it exists.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented
Status: Postponed (maintainer needs more info) » Needs review
Related issues: +#2606332: The migration form has hardcoded dependencies to database drivers

Note #2606332: The migration form has hardcoded dependencies to database drivers, which is really the same problem. I now understand why pgsql is an issue, it's not going to be presented if you don't have Postgres installed and running (I installed it a long time ago and apparently it's still running, which explains why I don't see this issue).

So, the ideal patch is a combination of the two - the other patch puts the logic in the main loop over the drivers, yours makes sure it only does its work if the 'host' key is present, so I'll consolidate and give you both credit.

  • mikeryan committed 98fd4e1 on 8.x-1.x 
    Issue #2598900 by googletorp,quietone: Move host settings iff there are...
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented
Status: Needs review » Fixed

Done, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.