The 'cols' value isn't long enough to get the full version string for the imageLoaded library.

CommentFileSizeAuthor
#2 fix_imagesLoaded_version-2597856-2.patch378 bytesBWPanda
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

BWPanda created an issue. See original summary.

BWPanda’s picture

BWPanda CreditAttribution: BWPanda commented
Status: Active » Needs review
FileSize
fix_imagesLoaded_version-2597856-2.patch378 bytes

Increased from 30 to 35.

Dom.’s picture

Dom. CreditAttribution: Dom. commented
Status: Needs review » Reviewed & tested by the community

  • Dom. committed 1c1720f on 7.x-3.x 
    Issue #2597856 by BWPanda: Fix imagesLoaded version number checking
Dom.’s picture

Dom. CreditAttribution: Dom. commented
Status: Reviewed & tested by the community » Fixed

Thanks BWPanda for reporting and fix ! This is now in 3.x-dev and will be included in next release.

BWPanda’s picture

BWPanda CreditAttribution: BWPanda commented

No worries. BTW, when I cloned from Git to make the patch I noticed 2.x was default branch, so I changed it to 3.x...

Dom.’s picture

Dom. CreditAttribution: Dom. commented

Thanks !

LIQUID VISUAL’s picture

LIQUID VISUAL CreditAttribution: LIQUID VISUAL commented

Using 3-dev, following instructions on Masonry API page, Drupal status report tells me:

"Error jQuery Masonry not detected

"The version of the Masonry library could not be detected."

The abovementioned patch has already been done (using dev version).

any tips or pointers for me?

many thanks!

cb

PS imagesloaded library registers just fine.

Dom.’s picture

Dom. CreditAttribution: Dom. commented

@LIQUIDE VISUAL: Did you had a look at #2532266: The version of the Masonry library could not be detected. ?
Did you downloaded the proper version of the library in the correct folder ?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.