Configuration

  • Supply a checklist of all vocabularies on the site. Recommend renaming the title of this area "Vocabularies to include in sitemap".
  • Supply available options for displaying vocabularies. See screenshot as a guide, but recommend using "vocabularies" in place of "categories".
  • Should only be visible when the taxonomy module is enabled.
  • Should only show "forum count" option when forum module is enabled. (not present in D7)

Display

  • Display selected vocabularies, reflecting the options that were selected.

Topics for discussion

  • Should the display of vocabularies be order-able, or should this module pull in the vocabulary weights from the taxonomy admin?
  • The "show titles" option is required in order to display the vocabulary name. Should this be configurable per sitemap element type? I could see wanting the titles for vocabularies, but not for the "Books" title or the individual menu names.
  • A link to the taxonomy/term/% page is not provided unless there is at least one node tagged with that term. I'm thinking that if the user has already enabled the option to show items without any nodes tagged, they should be okay with a link that goes to the default view with the "no items found" message.
  • For the counts threshold, should we continue to count only nodes? All entities? What does core do?
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akalata created an issue. See original summary.

akalata’s picture

Nafes’s picture

@akalata, how do you think about splitting this task to "getting it working" and extra bells and whistles? Maybe it's time to make a "Plan for Site map 8.x-1.0-alpha1 release" and put there a list of necessary tasks / issues?

akalata’s picture

I think we can stay on task and use the meta issue we have as a guide. I was mostly just taking notes as I was analyzing D7, but those don't need to hold up this issue.

I will want to tackle the theming changes before we hit an alpha, so I'll focus on getting that one done sooner rather than later.

Nafes’s picture

So, we can close this issue as "Closed (works as designed)" in order to have alpha countdown. Details will be still available for the future. And scope of meta issue is approximately a scope of alpha release for now. Am I right?

Anyway, it would be good to have two things:
- To have some alpha countdown.
- To keep your notes and ideas for future work.

akalata’s picture

Yes, I think the meta #2597780: [meta] Drupal 8 port of Site Map is good for alpha, or even the 8.x-1.0 release. I haven't gone through yet and tested out if the current dev works, or if there are small changes that might need to be made (like there was for books). I would also argue that the terminology change from "categories" to "vocabularies" should be made now.

I've been working in core a lot, so evidence of due diligence is pretty much how I work these days. :)

Nafes’s picture

:-)) Great! So, I will go through the functionality of the issue one more time an close it. Thanks again for your time and efforts!

Nafes’s picture

I have a bit different categories description (" Specify how many categories and subcategories should be included. Enter "-1" to include all categories and subcategories, "0" not to include categories at all, or "1" not to include subcategories.
") and also
Fatal error: Cannot access protected property Drupal\taxonomy\Entity\Vocabulary::$vid in /opt/lampp/htdocs/d8tst5/modules/site_map/src/SiteMapHelper.php on line 76.

Repository state is most recent on 8.x-1.x branch. Did I miss some patch?

akalata’s picture

The screenshots in the issue summary are from the Drupal 7 version. I have no idea what should or should not be working for D8 at this point. :)

Nafes’s picture

So, this issue is still open. :)

akalata’s picture

Posting my in-progress work on this task. Will require a reinstall since I've updated some of the setting names.

At a quick glance, functionality is working, but I have not thoroughly tested it manually or using the automated tests included in the module (those tests still need their namespaces updated, but the tests themselves should be updated for the new settings variables).

I've marked some @TODOs on things that need checks or improvements (translation support and format_plural), and begun marking places to cleanup code that is not currently used, though actually removing that should be another task (added for discussion in #2597780: [meta] Drupal 8 port of Site Map.

akalata’s picture

Status: Active » Needs review
FileSize
15.35 KB
1.37 KB

With this we can say functionality is working. Will make a separate issue for checking the tests (and updating the Categories namespace).

  • Nafes committed 31bfca1 on 8.x-1.x authored by akalata
    Issue #2597812 by akalata: D8 port: Configure and display site...
  • Nafes committed 8fd5fb7 on 8.x-1.x authored by akalata
    Issue #2597812 by akalata: D8 port: Configure and display site...
Nafes’s picture

Status: Needs review » Fixed

Congratulations! That works great! Thank you, @akalata!

akalata’s picture

Project: Site map » Sitemap

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.