Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The customized message display currently works, but is displaying HTML tags rather than using them.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | site_map_message-2597784-8.patch | 578 bytes | akalata |
| #3 | site_map_message-2597784-3.patch | 807 bytes | akalata |
| #2 | site_map_message-2597784-2.patch | 3.29 KB | akalata |
Comments
Comment #2
akalata CreditAttribution: akalata commentedPosting progress - getting site map message to render (that change must not have come over from my earlier patches), removing the namespacing of site_map_message variables. Also fixes code commenting in site-map.twig.html, though arguably that could be a separate issue. Now issue summary is up-to-date.
Comment #3
akalata CreditAttribution: akalata commentedIgnore #2. I was able to get this working with the least amount of effort. Lots of cleanup I'd like to do, but minimal changes are probably best to start with.
Comment #4
akalata CreditAttribution: akalata commentedThis is actually urgent because it fixes a bug that's causing WSOD on the /sitemap path.
Comment #6
Nafes CreditAttribution: Nafes as a volunteer commentedThis works. Great fix! Thank you, akalata!
Comment #7
akalata CreditAttribution: akalata commentedI may have talked one of my clients into sponsoring some of my work on this module since they use it for all their sites - in the meantime I'm happy to work on things where I can!
Comment #8
akalata CreditAttribution: akalata commentedNeed to reopen this - noticed that the
<p>tags didn't show up when restricted_html format was used, but when HTML is included (either in that filter or by changing the input filter), we see escaped code.Brand-new patch, earlier commit in #5 is still 100% good.
Comment #9
Nafes CreditAttribution: Nafes as a volunteer commentedGood to hear! I will try to commit your excellent patches without delays. Thank you for your time and efforts.
My fault. Attempted to commit the fix urgently :)
Brand new patch fixes <p> tags issue when the tags were entered to the message manually. But the tags are not added automatically on config saving, as supposed for restricted HTML. Any ideas? I guess, some extra parameter of the entry field on config form should do the job.
Comment #10
akalata CreditAttribution: akalata commentedI'm wondering if that's an issue with the restricted HTML filter itself. Switching into Basic or Full I'm able to add all sorts of tags.
Comment #12
Nafes CreditAttribution: Nafes as a volunteer commentedConfirmed. You are right. We can open a separate issue about restricted HTML filter on config form. I committed the change. If you have no more ideas about this particular issue, please close it as "Fixed". Thanks again for your efforts!
Comment #13
akalata CreditAttribution: akalata commentedYeah, let's create a new issue for that.
Comment #15
akalata CreditAttribution: akalata commented