CommentFileSizeAuthor
#9 site_map_form_nitpick-2597780-9.patch499 bytesakalata
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akalata created an issue. See original summary.

akalata’s picture

Issue summary: View changes
akalata’s picture

Issue summary: View changes
akalata’s picture

Adding here for discussion - I'd like to get the module up-to-date with best practices for theming (twig templates all around, no more theme functions!) before an official release. Functionality needs to come first, though, otherwise we'll have too many moving pieces.

Nafes’s picture

I completely agree. Very good suggestion!

Also your roadmap and closing it piece by piece are outstanding!

akalata’s picture

Issue summary: View changes
Nafes’s picture

Fixed #2599848: D8 cleanup: Remove site_map_ namespacing of config parameters. Name change of config parameters requires complete module uninstallation and re-installation. So, it is desirable to fix the issue early.

Also branch feature/dev-8-sync has been finished. It was kept mainly for this issue.

Nafes’s picture

Issue summary: View changes
akalata’s picture

An isolated patch for a small nitpick -- the main portion of the settings form should be open by default. This is the way it is in D7 and will improve findability of the key configuration options.

akalata’s picture

Issue summary: View changes

Consolidating notes on improvements and other ideas.

akalata’s picture

Issue summary: View changes
akalata’s picture

Issue summary: View changes
akalata’s picture

Issue summary: View changes
akalata’s picture

Issue summary: View changes
akalata’s picture

Issue summary: View changes
akalata’s picture

Issue summary: View changes

Almost there!

akalata’s picture

Issue summary: View changes
akalata’s picture

Issue summary: View changes
akalata’s picture

Issue summary: View changes
akalata’s picture

Issue summary: View changes
akalata’s picture

@Nafes, I think we're nearly there! I have a small patch in #9 that I'd love to see added.

Also wondering if there's been any discussion among the maintainers in regards to #2596861: Any chance of taking over the sitemap namespace? - if the module is going to move, that should probably get done before an alpha release, but that's not something I can really help with!

Nafes’s picture

@akalata, great! Really there! I will take care about the patch today in the evening.

I like the idea about taking over the sitemap namespace. I was going to see main module maintainer colan soon and discuss this with him. But we are moving very fast, so I will write him today. Anyway I don't see any problem, if alpha release will be published in this project. IMHO, it is better, than to have some delay.

  • Nafes committed c93ee74 on 8.x-1.x authored by akalata
    Issue #2597780 by akalata: [meta] Drupal 8 port of Site Map
    
Nafes’s picture

Сommitted. Thanks!

akalata’s picture

Project: Site map » Sitemap
akalata’s picture

Issue summary: View changes
akalata’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.