Problem/Motivation

Tmgmt config tests are broken since #2584603: PHP exception on manage fields after enabling Configuration Translation got commited, therefore we must find what is making the tests fail and fix it.

Proposed resolution

Find whats causing the issue and fix it.

Remaining tasks

create a patch, review and commit

User interface changes

API changes

None

Comments

juanse254 created an issue. See original summary.

Arla’s picture

Status: Active » Needs review
FileSize
753 bytes

I quickly tested locally and got rid of some of the fails with this. I'm not sure what the consequences are beyond the test, but the change seems reasonable to me.

Status: Needs review » Needs work

The last submitted patch, 2: configtests-2597285-2.patch, failed testing.

juanse254’s picture

This will get rid of the specific case of the nesting in the configui tests but despite that im not sure if that is what we are looking for, we need that case there.

Berdir’s picture

The idea of that change is that we avoid an additional nesting layer in e.g. the review UI if there is only a single file.

Berdir’s picture

Tracked down what exactly is causing this. #2598232: ConfigFactory::get() pollutes ::loadMultiple() static cache with new config objects now has proper fix.

Then we just need to update our config unit test and remove the nested key again that I recently added. tmgmt tests are green again with the core issue and this patch.

Status: Needs review » Needs work

The last submitted patch, 6: remove-nested-key-2597285-6.patch, failed testing.

The last submitted patch, 6: remove-nested-key-2597285-6.patch, failed testing.

Berdir’s picture

Status: Needs work » Fixed

Passes again now, great, committed.

  • Berdir committed 807672c on 8.x-1.x
    Issue #2597285 by Berdir, Arla: TMGMT tests failing due to recent core...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.