UUID 1.0-beta1 was recently released:

https://www.drupal.org/node/2581967

This issue is a little worrisome:

#2074599: Remove all Contrib module functions from uuid.core.inc, plus reference where UUID support is for contrib modules

If support for a contrib module was removed from UUID, but hasn't yet been merged into the contrib module in question, this update could break people depending on this module. :-/

It may make sense to postpone this issue until more contrib modules have had an opportunity to make releases.

CommentFileSizeAuthor
#14 panopoly_core-update-uuid-2597275-14.patch395 bytesdsnopek
#9 panopoly_core-update-uuid-2597275-9.patch395 bytesdsnopek
#8 update_uuid_to_version-2597275-8.patch401 byteshumansky
#3 update_uuid_to_version-2597275-3.patch401 byteshumansky

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue summary: View changes
Parent issue: » #2530998: [meta] Get Panopoly 1.x into maintenance mode (so we can focus on Drupal 8)
humansky’s picture

humansky commented
StatusFileSize
new update_uuid_to_version-2597275-3.patch401 bytes

Adding a patch file

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Postponed

Thanks for the patch!

After reviewing #2074599: Remove all Contrib module functions from uuid.core.inc, plus reference where UUID support is for contrib modules some more, I think it'd be best to hold off on this update until some more of those contrib module patches are committed. Otherwise, if someone is depending on Deploy, after upgrade some of parts of their content would mysteriously stop being deployed.

skwashd’s picture

skwashd commented

The background to #2074599: Remove all Contrib module functions from uuid.core.inc, plus reference where UUID support is for contrib modules is that the UUID team having to maintain a lot more code than we should've been. UUID has been refocused so it just deals with core. UUID Extras deals with the top 100 contrib modules. The rest is left to the contrib module maintainers.

@dsnopek, it has been around six months since the changes were committed. References has applied the patch, while the webform and entity_reference patches are marked as needs review. Requiring UUID 7.x-1.0-alpha6 in your make file means people can't benefit from of the other changes in UUID.

mpotter’s picture

mpotter commented

Wondering about the status of this. I share some of the concerns mentioned in #5. When a distribution includes a module, especially one in Alpha release, and then the module is updated to beta or more stable, we need to keep up-to-date with that or people using the distribution will run into compatibility problems with other modules.

In the example of #4, if a site is using Deploy and it breaks because of the update to UUID module, doesn't that just mean the site needs to update their version of Deploy?

Or, if nothing in Panopoly actually requires UUID, perhaps just removing it from the distro and then notifying users in the release notes that they must install UUID themselves if they need it on their site. Doesn't seem right for Panopoly to be burdened by a module it doesn't even use.

Or, do we just supplement this patch by adding the UUID Extras module mentioned in #5?

skwashd’s picture

skwashd commented
Title: Update UUID to version 1.0-beta1 » Update UUID to version 1.0-beta2

Updating title now after UUID beta 2 was released on 2 August.

humansky’s picture

humansky commented
Status: Postponed » Needs review
StatusFileSize
new update_uuid_to_version-2597275-8.patch401 bytes

Rerolling patch with the new version of UUID. Also, I'm reopening this issue as "needs review", since #2074599: Remove all Contrib module functions from uuid.core.inc, plus reference where UUID support is for contrib modules was closed. So I'm not sure if there as been any progress with @dsnopek's concerns in comment #6. For reference, here's the list of changes since alpha6 release:

https://www.drupal.org/project/uuid/releases/7.x-1.0-beta1

And here's the changes since beta 1 release:

https://www.drupal.org/project/uuid/releases/7.x-1.0-beta2

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Title: Update UUID to version 1.0-beta2 » Update UUID to version 1.0
StatusFileSize
new panopoly_core-update-uuid-2597275-9.patch395 bytes

uuid now has a 1.0 release! Here's a new patch.

Not many of the contrib patches have gotten committed, so, my concerns in #6 are still kind of a thing. That said, a lot of time has passed, and we can't wait forever. So, if we can get this out in a non-security release where we can announce it loud enough, we should try and get this in.

EDIT: For completeness, here's a travis build, even though we don't actually use the uuid module in the profile or tests: https://travis-ci.org/panopoly/panopoly/builds/323067338

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Needs review » Reviewed & tested by the community

We've had this in production for weeks without issue.

Jorrit’s picture

Jorrit commented

Why is UUID listed in panopoly_core.make anyway? The module is not a dependency of any panopoly module and having it as a module in the make file forces a certain version on users. I rather install it to sites/all/modules myself.

Never mind, this is discussed elsewhere.

byronveale’s picture

byronveale commented

Weeks? More like months now…

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

We have to do this eventually. It sucks that we may break some people who have been using Deploy and don't know that this is coming, especially in Panopoly 1.x. But I don't think we can put it off much longer!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Title: Update UUID to version 1.0 » Update UUID to version 1.1
StatusFileSize
new panopoly_core-update-uuid-2597275-14.patch395 bytes

Updating to be about UUID 1.1 which is a security release:

https://www.drupal.org/sa-contrib-2018-045

  • dsnopek committed 43945fd on 7.x-1.x 
    Update Panopoly Core for Issue #2597275 by dsnopek, humansky, skwashd,...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks, Everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.