Pathauto 1.3 was recently released:

https://www.drupal.org/node/2582001

The biggest and most important change for us, is that this patch is finally merged:

https://www.drupal.org/node/936222

We need to make sure that updates work. I'm particularly concerned that the hook_update_N() function may have been renumbered since the last version of the patch that we used.

There were also lots of other changes in this release, so we need to make sure that they don't cause any problems for other functionality (like the panopoly_pages customizations).

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

  • dsnopek committed 9eef362 on 7.x-1.x
    Update Panopoly Core for Issue #2597273: Update to Pathauto 1.3
    
dsnopek’s picture

Status: Active » Fixed

Worked in my manual testing. I'm so excited about this change, that I've just committed it. ;-) And we'll see what Travis-CI says:

https://travis-ci.org/panopoly/panopoly/builds/88186696

dsnopek’s picture

Status: Fixed » Active

This causes some Features to be overridden:

https://travis-ci.org/panopoly/panopoly/jobs/88186697#L629

This is breaking the tests. Reverting for now...

  • dsnopek committed c329580 on 7.x-1.x
    Revert "Update Panopoly Core for Issue #2597273: Update to Pathauto 1.3"
    

  • dsnopek committed 9eef362 on 8.x-2.x
    Update Panopoly Core for Issue #2597273: Update to Pathauto 1.3
    
  • dsnopek committed c329580 on 8.x-2.x
    Revert "Update Panopoly Core for Issue #2597273: Update to Pathauto 1.3"
    
dsnopek’s picture

Status: Active » Needs review
FileSize
521 bytes

Here's a patch. Need to try the tests on Travis again!

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/166511599

dsnopek’s picture

Assuming the same things that broke last time we ran the tests, then these patches might fix it

EDIT: It was the same failures! Here's a build with the new patches: https://travis-ci.org/panopoly/panopoly/builds/166514876

dsnopek’s picture

FileSize
934 bytes

So, it's complaining that panopoly_pages should have:

features[variable][] = pathauto_taxonomy_term_panopoly_categories_pattern

... but that doesn't actually make sense, because panopoly_core is what is declaring that Taxonomy vocabulary - I'm not sure what panopoly_pages has to do with it.

But here's a patch to exclude that too, just so we can move this forward.

EDIT: Here's the new build: https://travis-ci.org/panopoly/panopoly/builds/166521744

  • dsnopek committed b38fd1b on 7.x-1.x
    Update Panopoly Core and Pages for Issue #2597273 by dsnopek: Update to...
dsnopek’s picture

Status: Needs review » Fixed

Last test build passed, so... committed! Finally!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.