Tested this on a clean D8 RC1 install with the git checkout of 8.x-1.x as of about 30 minutes ago. So this already includes #2584835: Title tags are double-encoded
To repro:
- Clean D8 RC1 with only Metatags installed (no pathauto needed)
- Add a metatag field to article. Leave all the defaults blank.
- Create a new article.
- Set node title to
Test metatag's apostrophe handling
- Set metatag Page Title to [node:title]
- Save node.
Node title will show as Test metatag's apostrophe handling
Next:
- Edit the node.
- Change title to
Test metatag’s apostrophe handling
. (The apostrophe is slightly different.) - Save node.
Title now displays correctly.
I don't know where that other kind of apostrophe is coming from on the client site. It's not on my keyboard. Possibly it's being copied from a word processor? At any rate, the "fancy" apostrophe works but the regular one does not.
I assigned to myself because I'm still looking into it but if anyone happens to know what's going on feel free to jump in. :)
Comment | File | Size | Author |
---|---|---|---|
#2 | metatag-apostrophe-encoding-2596753-3.patch | 802 bytes | Michelle |
|
Comments
Comment #2
MichelleThe documentation of html_entity_decode() indicates that it defaults to ignoring apostrophes so passed in the parameter that includes apostrophes and it is handling apostrophes (both kinds) and double quotes properly now.
Comment #3
MichelleForgot status.
Comment #4
DamienMcKennaFTR: http://php.net/html_entity_decode
Comment #5
DamienMcKennaComment #6
DamienMcKennaCommitted. Thanks Michelle!
Comment #8
DamienMcKenna