Deleting a view should rebuild the routes

Hi

Followed your steps to generate the issue:
On Drupal 8.0.0-dev, I am not able to generate it.

Thoughts?

Actually we need to clear cache programetically after deletion of any view.
@lhuria94 - Please follow below steps.
1. Open /glossary in new tab.
2. Delete Glossary view.
3. Go to /glossary link tab and reload your tab.

okay, I checked again.
Its shows WSOD on the page when I go to /glossary link after the deletion of the view.

+++ b/core/modules/views/src/Entity/View.php
@@ -423,6 +423,7 @@ public static function postDelete(EntityStorageInterface $storage, array $entiti
+    drupal_flush_all_caches();

Isn't it enough to call \Drupal::service('router.builder')->setRebuildNeeded(); ?

Thanks @dawehner changes done as you suggested.

Yeah we need

Added test

+++ b/core/modules/views_ui/src/Tests/DefaultViewsTest.php
@@ -142,6 +142,19 @@ function testDefaultViews() {
+
+    // Delete all duplicated Glossary views.
+    $this->drupalGet('admin/structure/views');
+    $this->clickViewsOperationLink(t('Delete'), 'duplicate_of_glossary');
+    // Submit the confirmation form.
+    $this->drupalPostForm(NULL, array(), t('Delete'));
+    $this->drupalGet('admin/structure/views');
+    $this->clickViewsOperationLink(t('Delete'), $random_name);
+    // Submit the confirmation form.
+    $this->drupalPostForm(NULL, array(), t('Delete'));
+    $this->drupalGet('glossary');
+    $this->assertResponse(404);
+    $this->assertText('Page not found');

Ideally we would add a drupalGet('/glossary') with assertResponse(200) to ensure that really this state changed.

Lets add that then, first check that /glossary is indeed a 200, then delete, then check 404.

Thank you for expanding the test coverage!

I discussed this with @dawehner and we concluded that views should implement the delete hook and do it there - because when hooks become events, or something else OO then we'll do the injection properly.

+++ b/core/modules/views/views.module
@@ -804,3 +805,11 @@ function views_local_tasks_alter(&$local_tasks) {
+  // Rebuild routes after deleting a view.
+  \Drupal::service('router.builder')->setRebuildNeeded();

We could check whether the view has any routes and just in that particular case rebuild the router ...

Awesome, thank you!

Committed b6b7891 and pushed to 8.0.x and 8.1.x. Thanks!

Now we have to remove the rebuilds in PastDBTest::testViews and the @todo messages, not sure if here or in a followup.

Sorry for that, I thougt that it was in the module.

Now we have to remove the rebuilds in PastDBTest::testViews and the @todo messages, not sure if here or in a followup.

If you find any in views, feel free to open a follow up!