The paragraph at the top of the module's admin config page does not appear. #value in the render array must be replaced with #markup.

CommentFileSizeAuthor
#18 2596107-18.patch1.27 KBJeroenT
#10 one-line-patch-help-text-above-config-options-not-visible-2596107.patch1.02 KBashwinsh
#6 2596107.patch1.02 KBjalpesh
#4 html_title_admin_descrV2.patch691 bytesjalpesh
html_title_admin_descr.patch691 bytesRdeBoer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RdeBoer created an issue. See original summary.

kreynen’s picture

kreynen CreditAttribution: kreynen at University of Colorado Boulder commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, html_title_admin_descr.patch, failed testing.

jalpesh’s picture

jalpesh CreditAttribution: jalpesh as a volunteer and at Cybage Software Pvt Ltd. commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
html_title_admin_descrV2.patch691 bytes

I think the patch was not proper. I have attach another one.

Status: Needs review » Needs work

The last submitted patch, 4: html_title_admin_descrV2.patch, failed testing.

jalpesh’s picture

jalpesh CreditAttribution: jalpesh as a volunteer and at Cybage Software Pvt Ltd. commented
FileSize
2596107.patch1.02 KB
jalpesh’s picture

jalpesh CreditAttribution: jalpesh as a volunteer and at Cybage Software Pvt Ltd. commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: 2596107.patch, failed testing.

The last submitted patch, 6: 2596107.patch, failed testing.

ashwinsh’s picture

ashwinsh
He/Him
Primary language English
Location Pune
CreditAttribution: ashwinsh as a volunteer and at Cybage Software Pvt Ltd. commented
FileSize
one-line-patch-help-text-above-config-options-not-visible-2596107.patch1.02 KB

Added new patch file.

ashwinsh’s picture

ashwinsh
He/Him
Primary language English
Location Pune
CreditAttribution: ashwinsh as a volunteer and at Cybage Software Pvt Ltd. commented
Status: Needs work » Needs review
dcam’s picture

dcam CreditAttribution: dcam commented
Title: ONE LINE PATCH Help text above config options not visible » Help text above config options not visible
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I tested the original patch in the issue summary. It applied and worked just fine so this is RTBC. The test errors were a result of problems with the test client and the patches that followed were unnecessary.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

the CI error is likely due to the need to merge 1.4 into 1.x as described in
#2469031: creates broken handler in views
looks like a bit of a glitch in the git repo, could likely be solved as described in 2469031

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: one-line-patch-help-text-above-config-options-not-visible-2596107.patch, failed testing. View results

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs work » Reviewed & tested by the community

Again, the original patch is still good.

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
CreditAttribution: generalredneck commented

@dcam

Thanks for all the review. This will all be addressed soon... but for now hang tight and keep up the good work testing these out! 👍

dcam’s picture

dcam CreditAttribution: dcam commented

I understand - security issue first. Just updating these couple of issues that I've been involved in, especially since this one was set to Needs Work by Testbot.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
FileSize
2596107-18.patch1.27 KB

Moved the description to hook_help.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented

Moved the description to hook_help.

  • JeroenT committed 12ef009 on 7.x-1.x 
    Issue #2596107 by jalpesh, RdeBoer, ashwinsh, JeroenT: Help text above...
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x-1.x. Thanks!

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

Thanks @JeroenT, feel free to tag and release at will.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.