The workflow_notify submodule is not yet ported to D8.

However, there is a new contrib module workflow_notifiations, which we will use in the future.

CommentFileSizeAuthor
#10 2595923-port-workflow_notify-10.patch20.58 KBceaucari
#4 2595923-4.patch41.7 KBheykarthikwithu

Comments

johnv created an issue. See original summary.

johnv’s picture

johnv
Primary language Dutch
commented
Component: Workflow Access: Code » Code
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: Unassigned » heykarthikwithu
Status: Active » Needs work

Will start with DrupalModuleUpgrader.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2595923-4.patch41.7 KB

Status: Needs review » Needs work

The last submitted patch, 4: 2595923-4.patch, failed testing.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Needs work » Needs review
johnv’s picture

johnv
Primary language Dutch
commented

See also the applied patches on the D7-version at:
https://www.drupal.org/project/issues/workflow?text=notify&status=All&pr...

johnv’s picture

johnv
Primary language Dutch
commented
Component: Code » Workflow Notifications
saranya ashokkumar’s picture

saranya ashokkumar commented

I have reviewed that patch. hook_workflow() will get call on immediate state change. On cron state change this hook is not getting call So only I have created the above patch. Is there any other hook for cron state change?

ceaucari’s picture

ceaucari commented
StatusFileSize
new 2595923-port-workflow_notify-10.patch20.58 KB

Here is a working port of the module.

saranya ashokkumar’s picture

saranya ashokkumar commented

Hi,

I have created a module for workflow notify here. I think it will be good, if it is sub-module to workflow.

Please review and suggest...

anas_maw’s picture

anas_maw commented

Hello,
I had a quick review on the patch and the submodule.
I prefer to not use a submodule when this module already has a plan to port workflow_notify unless providing another features.
Is it possible to make notification general and then we can choose the notification method, for example Email, sms, push notification, etc..
Providing a good api for this will be very helpful.
Thanks,

anas_maw’s picture

anas_maw commented

The last patch cause the following error after adding a new notification and go to notifications list page
Symfony\Component\Routing\Exception\MissingMandatoryParametersException: Some mandatory parameters are missing to generate a URL for route "entity.workflow_notification.config_translation_overview

johnv’s picture

johnv
Primary language Dutch
commented

After reviewing the patches in #4, #10 and #11, i decided to go along with #11. A commit will be created shortly.

johnv’s picture

johnv
Primary language Dutch
commented
Title: [D8-port task] port workflow_notify » [D8-port task] port workflow_notify >> workflow_notifications
Version: 8.x-1.x-dev » 8.x-1.0
Issue summary: View changes
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.