In Drupal 8, the minimal profile doesn't include a minimal.profile. As a result, we won't see it in the packages, nor will it be available during site install.

CommentFileSizeAuthor
#18 interdiff-2595809-13-18-do-not-test.patch1.44 KBcolan
#18 provision-find_d8_profiles-2595809-18.patch3.26 KBcolan
#13 interdiff-2595809-12-13-do-not-test.patch489 bytescolan
#13 provision-find_d8_profiles-2595809-13.patch2.21 KBcolan
#12 interdiff-2595809-10-12-do-not-test.patch966 bytescolan
#12 provision-find_d8_profiles-2595809-12.patch1.86 KBcolan
#10 find_d8_profiles-2595809-10.patch1.48 KBhelmo
#3 find_d8_profiles-2595809-3.patch1.14 KBhelmo

Comments

ergonlogic created an issue. See original summary.

gboudrias’s picture

gboudrias commented

Just tested and this is still active, we can't install using Minimal (or Testing).

helmo’s picture

helmo commented
Status: Active » Needs review
StatusFileSize
new find_d8_profiles-2595809-3.patch1.14 KB

.profile files seem optional ... It's all about the .info.yml

This patch seems to do the trick.

  • gboudrias committed 4eb1ba7 on 7.x-3.x authored by helmo 
    Issue #2595809 by helmo: Find (d8) profiles without a .profile
gboudrias’s picture

gboudrias commented
Status: Needs review » Fixed
Issue tags: +Aegir 3.3

Works great, pushed :)

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Fixed » Needs work

I believe this'll need further work, or at least thorough testing. I believe $profile->filename gets include()'d somewhere further down the line in the install process. I believe it's to find any implementations of hook_requirements, if memory serves...

gboudrias’s picture

gboudrias commented

You're right, I was a bit over-eager, it seems Verify fails on Hostmaster because of the README.txt:

require_once(./profiles/README.txt/README.txt.info): failed to open stream: No such file or directory provision_drupal.drush.inc:429

Drush command terminated abnormally due to an unrecoverable error. Error: require_once(): Failed opening required './profiles/README.txt/README.txt.info' (include_path='.:/usr/share/php:/usr/share/pear') in /usr/share/drush/commands/provision/platform/provision_drupal.drush.inc, line 429

gboudrias’s picture

gboudrias commented

Reverted for now as the same bug breaks the hostmaster install.

  • gboudrias committed cc080cf on 7.x-3.x 
    Revert "Issue #2595809 by helmo: Find (d8) profiles without a .profile...
helmo’s picture

helmo commented
StatusFileSize
new find_d8_profiles-2595809-10.patch1.48 KB

I see that Jenkins also failed a Job on this ... http://ci.aegirproject.org/job/U_aegir_6.x-2.x_to_7.x-3.x_upgrade/458/co...

This looks better, hostmaster and a D8 platform verified.

miroslavbanov’s picture

miroslavbanov commented

#10 patch looks wrong:

      if (!file_exists($profile_file)) {
        require_once($profile_file);
      }

Require it if it doesn't exist?

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Needs work » Needs review
StatusFileSize
new provision-find_d8_profiles-2595809-12.patch1.86 KB
new interdiff-2595809-10-12-do-not-test.patch966 bytes

That should be reversed.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
StatusFileSize
new provision-find_d8_profiles-2595809-13.patch2.21 KB
new interdiff-2595809-12-13-do-not-test.patch489 bytes

Fixed:

Undefined property: stdClass::$version provision_drupal.drush.inc:590

helmo’s picture

helmo commented

Added a PR for testing https://github.com/aegir-project/provision/pull/7

  • helmo committed 2840bc4 on 7.x-3.x authored by colan 
    Issue #2595809 by colan, helmo: Find (d8) profiles without a .profile
helmo’s picture

helmo commented
Status: Needs review » Needs work

regression ... 'README.txt' showing up as a profile: https://usercontent.irccloud-cdn.com/file/t7BP6wND/Install%20profile%3A%...

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Assigned: Unassigned » colan

It's definitely this commit. Just confirmed with git bisect.

Seeing this in the verify log on D7 platforms (testing with dkan):

  • Found install profile Icon
  • Found install profile dkan
  • Found install profile pantheon
  • Found install profile README.txt

...when it should just be:

  • Found install profile dkan
  • Found install profile pantheon

Investigating...

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Needs work » Needs review
StatusFileSize
new provision-find_d8_profiles-2595809-18.patch3.26 KB
new interdiff-2595809-13-18-do-not-test.patch1.44 KB

I think I fixed it. Files weren't being skipped. We should only be looking into directories.

  • colan committed f49ad95 on 7.x-3.x 
    Issue #2595809: Revert "Issue #2595809 by colan, helmo: Find (d8)...

  • helmo committed 5de479c on 7.x-3.x authored by colan 
    Issue #2595809 by colan, helmo: Find (d8) profiles without a .profile
helmo’s picture

helmo commented
Assigned: colan » Unassigned
Status: Needs review » Fixed

It works as expected with the new patch.

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented

On a side note... Drupal itself has code that detects these profiles. Maybe in the future we look at how we might offload this logic to that?

This is one of those parts we need to address if we are to properly support anything other than drupal.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.