Reference php.net 'international' URL in help text [#2591919]

This is a followup to #2496943: Add condition to ignore PHP 7 on rest requirements check.

Problem/Motivation

As per David_Rothstein's comment in #2456025-28: PHP warnings in PHP 5.6 because of always_populate_raw_post_data ini setting (the D7 version of this issue):
+ 'description' => t('The always_populate_raw_post_data PHP setting should be set to -1 in PHP versions 5.6 and up. Please check the <a href="https://php.net/manual/en/ini.core.php#ini.always-populate-raw-post-data">PHP manual</a> for information on how to correct this.'),

We usually like to leave the /en/ out of php.net URLs in the user interface. That way we don't assume a language and the user gets sent to the correct language via whatever mechanism php.net uses to detect that.

Proposed resolution

Remove '/en' part from URL. in the file (core/modules/rest/rest.install).

Optionally, run a search for php.net/manual/en through core files to see if you spot more occurrences.

Remaining tasks

Do it.

User interface changes

API changes

Data model changes

None.

Comment	File	Size	Author
#7	php.net-2591919-7.patch	20 KB	snehi
#7	8.0.x: PHP 5.5 & MySQL 5.5 14,218 pass
#4	interdiff-2-4.txt	2.08 KB	sdstyles
#4	php.net-2591919-4.patch	21.16 KB	sdstyles
#4	8.0.x: PHP 5.5 & MySQL 5.5 14,218 pass
#2	php.net-2591919-2.patch	21.17 KB	sdstyles
#2	8.0.x: PHP 5.5 & MySQL 5.5 14,218 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

13 October 2015 at 23:12

roderik created an issue. See original summary.

Comment #2

sdstyles CreditAttribution: sdstyles at FFW commented 14 October 2015 at 00:26

Status:

Active

» Needs review

File	Size
php.net-2591919-2.patch	21.17 KB
8.0.x: PHP 5.5 & MySQL 5.5 14,218 pass

Removed all occurrences of php.net/manual/en

Comment #3

GoZ CreditAttribution: GoZ at Centarro commented 14 October 2015 at 08:06

Status:

Needs review

» Needs work

+++ b/core/lib/Drupal/Component/Datetime/DateTimePlus.php
@@ -177,7 +177,7 @@ public static function createFromTimestamp($timestamp, $timezone = NULL, $settin
-   *   @see http://us3.php.net/manual/en/datetime.createfromformat.php
+   *   @see http://us3.php.net/manual/datetime.createfromformat.php

us3 subdomain should be deleted to.

+++ b/core/lib/Drupal/Component/Datetime/DateTimePlus.php
@@ -389,7 +389,7 @@ protected function prepareFormat($format) {
+   * @see http://us3.php.net/manual/time.getlasterrors.php

Remove us3 subdomain

+++ b/core/modules/views/src/Plugin/views/field/Date.php
@@ -111,7 +111,7 @@ public function buildOptionsForm(&$form, FormStateInterface $form_state) {
+      '#description' => $this->t('If "Custom", see <a href="http://us.php.net/manual/function.date.php" target="_blank">the PHP docs</a> for date formats. Otherwise, enter the number of different time units to display, which defaults to 2.'),

Remove us subdomain.

Comment #4

sdstyles CreditAttribution: sdstyles at FFW commented 14 October 2015 at 08:49

Status:

Needs work

» Needs review

File	Size
php.net-2591919-4.patch	21.16 KB
8.0.x: PHP 5.5 & MySQL 5.5 14,218 pass
interdiff-2-4.txt	2.08 KB

Removed us subdomain.
Thanks

Comment #5

GoZ CreditAttribution: GoZ at Centarro commented 14 October 2015 at 10:08

Status:

Needs review

» Reviewed & tested by the community

Thanks @sdstyles, looks fine.

Comment #6

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Chapter Three commented 15 October 2015 at 10:28

Status:

Reviewed & tested by the community

» Needs work

+++ b/core/modules/views/src/Plugin/views/field/Date.php
@@ -111,7 +111,7 @@ public function buildOptionsForm(&$form, FormStateInterface $form_state) {
-      '#description' => $this->t('If "Custom", see <a href="http://us.php.net/manual/en/function.date.php" target="_blank">the PHP docs</a> for date formats. Otherwise, enter the number of different time units to display, which defaults to 2.'),
+      '#description' => $this->t('If "Custom", see <a href="http://php.net/manual/function.date.php" target="_blank">the PHP docs</a> for date formats. Otherwise, enter the number of different time units to display, which defaults to 2.'),

This is a translatable string and therefore not incorrect. All the other changes in this patch are rc eligible - this one is not - we're in string freeze and this is not a bug.

Comment #7

snehi CreditAttribution: snehi as a volunteer and at Publicis Sapient for Publicis Sapient commented 15 October 2015 at 20:09

Status:

Needs work

» Needs review

File	Size
php.net-2591919-7.patch	20 KB
8.0.x: PHP 5.5 & MySQL 5.5 14,218 pass

As mentioned by @Alex removing change in #6.

Comment #8

snehi CreditAttribution: snehi as a volunteer and at Publicis Sapient for Publicis Sapient commented 15 October 2015 at 20:17

Parent issue:		» #2571845: Links to wikipedia/php.net should be part of the actual t() string so they can be localized
Related issues:		+#2571845: Links to wikipedia/php.net should be part of the actual t() string so they can be localized

same issue is here might be duplicate one

https://www.drupal.org/node/2571845

or can be considered as child issue.

Comment #9

snehi CreditAttribution: snehi as a volunteer and at Publicis Sapient for Publicis Sapient commented 16 October 2015 at 09:09

Assigned:

Unassigned

» snehi

Comment #10

jhodgdon

she/her

English

CreditAttribution: jhodgdon as a volunteer commented 16 October 2015 at 15:10

Yes this is a duplicate of #2571845: Links to wikipedia/php.net should be part of the actual t() string so they can be localized, which has a better issue summary. I don't think this patch probably fixes everything listed there, but can you upload this patch to the other issue so we can continue there with the fixes?