We currently have the FacetAdapter but it doesn't actually adapt anything, we decided a better name should be FacetManager.

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Title: FacetAdapter is a confusing, should be FacetManager. » FacetAdapter is a confusing name, should be FacetManager.
jurcello’s picture

jurcello CreditAttribution: jurcello at Triquanta commented
Assigned: Unassigned » jurcello

  • jurcello committed 2e00f30 on 8.x-1.x 
    Issue #2588787 by jurcello: FacetAdapter is a confusing name, should be...
jurcello’s picture

jurcello CreditAttribution: jurcello at Triquanta commented

I renamed it.

jurcello’s picture

jurcello CreditAttribution: jurcello at Triquanta commented
Assigned: jurcello » Unassigned
Status: Active » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Needs work

@jurcello

  1. You updated the developer docu but that document is out of date on more than just this namechange, we should open a followup to discuss what to do with that file; update or delete it.
  2. For some reason, this commit readded src/Plugin/facetapi/query_type/QueryTypeTerm.php, that was previously removed in baf4b4f9d5da399e3c9409399f051c14d3e95034. This should be in the search api patch: #2493599: Make our data type system more easily understandable

Otherwise this is a straight up rename so I think it's good to open a followup for .1 and we can just remove QueryTypeTerm again.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs work » Fixed

The current patch over in #2493599: Make our data type system more easily understandable has removed the QueryTypeTerm again so it should stay in facet api. My concerns in #7.2 are not valid anymore.

Opened a followup for #7.1 so this issue can be closed. See #2599838: Update or remove developer-docu.md.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.