Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Core has some unused images. Many are now SVG or have had their usages removed over the course of the 8.0.x cycle.
Proposed resolution
Go through all the images, see if they are used. Remove them if they are not used in core.
Images to remove
core/misc/menu-leaf.png
core/modules/contextual/images/gear-select.png
core/modules/user/images/icon-user-active.png
core/modules/user/images/icon-user.png
core/modules/views_ui/images/arrow-active.png
core/modules/views_ui/images/close.png
core/modules/views_ui/images/expanded-options.png
core/modules/views_ui/images/loading.gif
core/modules/views_ui/images/overridden.gif
core/modules/views_ui/images/status-active.gif
Only used in tests (maybe they could be moved to a test location)
core/misc/loading.gif
Remaining tasks
Audit
Patch
Review
User interface changes
None
API changes
n/a
Data model changes
n/a
Comment | File | Size | Author |
---|---|---|---|
#5 | remove_unused_image_files_from_core-2588373-5.patch | 13.58 KB | chhavik |
Comments
Comment #2
star-szrI did a fairly quick audit of core/modules (core/misc should still be looked at) and the list is not massive, updated the issue summary.
Comment #3
star-szrComment #4
chhavik CreditAttribution: chhavik commentedComment #5
chhavik CreditAttribution: chhavik as a volunteer commentedFound 1 image to be removed under core/misc and added it to Cottser's list. This patch removed the following images.
Images to remove:
core/modules/contextual/images/gear-select.png
core/modules/user/images/icon-user-active.png
core/modules/user/images/icon-user.png
core/modules/views_ui/images/arrow-active.png
core/modules/views_ui/images/close.png
core/modules/views_ui/images/expanded-options.png
core/modules/views_ui/images/loading.gif
core/modules/views_ui/images/overridden.gif
core/modules/views_ui/images/status-active.gif
core/misc/menu-leaf.png
Comment #6
snehi CreditAttribution: snehi as a volunteer and at Publicis Sapient for Publicis Sapient commented@chhavik Thanks for creating the patch.
Going to test this.
Comment #7
snehi CreditAttribution: snehi as a volunteer and at Publicis Sapient for Publicis Sapient commentedSuccessfully deleting all the mentioned files.
Thanks for the patch.
This is RTBC now.
Comment #9
snehi CreditAttribution: snehi as a volunteer and at Publicis Sapient for Publicis Sapient commentedComment #10
snehi CreditAttribution: snehi as a volunteer and at Publicis Sapient for Publicis Sapient commentedComment #11
xjmThanks for the patch! I think we need to move this to 8.1.x now, in case some specific site or theme was using these images that are not used in core.
Comment #12
alexpottBefore we can remove all these image we need a change record for themers saying they are going to be removed. https://www.drupal.org/node/add/changenotice?field_project=3060
Comment #13
star-szrThanks @xjm @alexpott! https://www.drupal.org/node/2623760 :)
Comment #14
star-szrComment #15
joelpittetOh yes. RTBC++
Comment #16
alexpottCommitted 2d76033 and pushed to 8.1.x. Thanks!
Comment #18
tim.plunkettThose views_ui images *should* have still been used, they were incorrectly removed in #2408525: Rewrite Views UI CSS inline with our CSS standards - Part 1.