Problem/Motivation

Core has some unused images. Many are now SVG or have had their usages removed over the course of the 8.0.x cycle.

Proposed resolution

Go through all the images, see if they are used. Remove them if they are not used in core.

Images to remove

core/misc/menu-leaf.png
core/modules/contextual/images/gear-select.png
core/modules/user/images/icon-user-active.png
core/modules/user/images/icon-user.png
core/modules/views_ui/images/arrow-active.png
core/modules/views_ui/images/close.png
core/modules/views_ui/images/expanded-options.png
core/modules/views_ui/images/loading.gif
core/modules/views_ui/images/overridden.gif
core/modules/views_ui/images/status-active.gif

Only used in tests (maybe they could be moved to a test location)

core/misc/loading.gif

Remaining tasks

Audit
Patch
Review

User interface changes

None

API changes

n/a

Data model changes

n/a

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Cottser created an issue. See original summary.

star-szr’s picture

Issue summary: View changes
Issue tags: +Novice

I did a fairly quick audit of core/modules (core/misc should still be looked at) and the list is not massive, updated the issue summary.

star-szr’s picture

Issue summary: View changes
chhavik’s picture

Assigned: Unassigned » chhavik
chhavik’s picture

Assigned: chhavik » Unassigned
Status: Active » Needs review
FileSize
13.58 KB

Found 1 image to be removed under core/misc and added it to Cottser's list. This patch removed the following images.

Images to remove:

core/modules/contextual/images/gear-select.png
core/modules/user/images/icon-user-active.png
core/modules/user/images/icon-user.png
core/modules/views_ui/images/arrow-active.png
core/modules/views_ui/images/close.png
core/modules/views_ui/images/expanded-options.png
core/modules/views_ui/images/loading.gif
core/modules/views_ui/images/overridden.gif
core/modules/views_ui/images/status-active.gif
core/misc/menu-leaf.png

snehi’s picture

Status: Needs review » Needs work

@chhavik Thanks for creating the patch.
Going to test this.

snehi’s picture

Status: Needs work » Reviewed & tested by the community

Successfully deleting all the mentioned files.
Thanks for the patch.
This is RTBC now.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: remove_unused_image_files_from_core-2588373-5.patch, failed testing.

snehi’s picture

Status: Needs work » Needs review
snehi’s picture

Status: Needs review » Reviewed & tested by the community
xjm’s picture

Version: 8.0.x-dev » 8.1.x-dev

Thanks for the patch! I think we need to move this to 8.1.x now, in case some specific site or theme was using these images that are not used in core.

alexpott’s picture

Issue tags: +Needs change record

Before we can remove all these image we need a change record for themers saying they are going to be removed. https://www.drupal.org/node/add/changenotice?field_project=3060

star-szr’s picture

Issue tags: -Needs change record

Thanks @xjm @alexpott! https://www.drupal.org/node/2623760 :)

star-szr’s picture

Issue summary: View changes
joelpittet’s picture

Oh yes. RTBC++

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 2d76033 and pushed to 8.1.x. Thanks!

  • alexpott committed 2d76033 on 8.1.x
    Issue #2588373 by chhavik, Cottser: Remove unused image files from core
    
tim.plunkett’s picture

Those views_ui images *should* have still been used, they were incorrectly removed in #2408525: Rewrite Views UI CSS inline with our CSS standards - Part 1.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.