After this issue #2568887: Allow the Plugins to add validations for the settings form we found a failing test https://qa.drupal.org/pifr/test/1167738, we didn't solve it in this issue finally #2572623: Add validations for the settings form as we needed to fix the settings form fast.

Now it's time to find what is causing that failing test and solve it.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

edurenye created an issue. See original summary.

juanse254’s picture

Assigned: Unassigned » juanse254
juanse254’s picture

Status: Active » Needs review

Currently with #2545370: Add Simple Response object to Gengo Plugin and #1420364: A simple response object for methods which need to return a true/false *and* a message the test in gengo is passing locally. Im not sure why, please someone else test to make sure that is correct. If thats the case we should set the other 2 to RTBC and close this issue.

miro_dietiker’s picture

Status: Needs review » Active

Strange things...

Fatal error: Call to a member function id() on a non-object in /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/node/src/Tests/NodeTypeInitialLanguageTest.php on line 108

Call to undefined method Drupal\node\Controller\NodeController::getRevisionDetails()

Was this a temporary situation?

Only set to "Needs review" if patches provided. See issue status guideline.

juanse254’s picture

Status: Active » Needs review
FileSize
1.08 KB

This should fix it.

miro_dietiker’s picture

Status: Needs review » Fixed

Awesome - crossing fingerz... ;-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.