New check #2570285: Make sure TranslatableMarkup accepts string values only introduced just before RC1 breaks our installation procedure with error:

exception 'InvalidArgumentException' with message '$string ("Your new site !site has been created.") must be a string.' in /var/aegir/platforms/drupal-8.0.0-rc1/core/lib/Drupal/Core/StringTranslation/TranslatableMarkup.php:83

Comments

omega8cc created an issue. See original summary.

omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented

Related Drush discussion: https://github.com/drush-ops/drush/issues/1637#issuecomment-143784752

omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented

It started in Drupal here: #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand

omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented

I should add that we are testing this using latest Drush 8 (master), so we are probably affected by https://github.com/drush-ops/drush/pull/1647

omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented

We should get rid of any remaining st() and t() and use Drush wrapper dt() everywhere. This fixes the problem. The only remaining cosmetic issue is that !site gets forward slashes on both sides in the mail body. This doesn't affect mail subject, though. No idea, why?

omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented
Title: Drupal-8.0.0-c1 breaks installation » Drupal-8.0.0-rc1 breaks installation
omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented
Title: Drupal-8.0.0-rc1 breaks installation » Remove any remaining st() and t() and use Drush wrapper dt() everywhere

Better Title.

  • omega8cc committed 631354b on 7.x-3.x 
    Issue #2583119 - Remove any remaining st() and t() and use Drush wrapper...
omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented
Status: Active » Fixed

Problem fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

gboudrias’s picture

gboudrias CreditAttribution: gboudrias at Praxis Labs Coop commented
Issue tags: +Aegir 3.2