CCK type cache not updated on node type creation

node_type_save() calls content_type_create() which correctly notes that:

 * node_get_types() is still missing the new type at this point, so no
 * use to call content_clear_type_cache() or menu_rebuild() here. Instead
 * we set a flag to make sure it gets rebuilt on next page load.

node_get_types() keeps a static cache of node types which is not reset by node_type_save(). This is certainly a bug in node.module. chx and I are working on a general static caching solution, but it isn't in yet.

However, there is still a CCK bug. Since clearing the CCK cache is currently useless at that point, content_type_create() stores a boolean in $_SESSION to indicate that the cache should be cleared on the next page load. That's fine unless node_type_save() is not called from a page request but from a normal program. Then there is no subsequent load for the $_SESSION and the cache is never cleared.

You could set a variable instead of setting the flag in $_SESSION. That might lead to a race condition in which more than one "next page request" actually clears the cache. There is no good solution to the race condition but in this case at least clearing the type cache is merely a temporary performance hit, not a real problem.

However, I notice that node_get_types() has a reset argument:

function node_get_types($op = 'types', $node = NULL, $reset = FALSE);

Why not call node_get_types(NULL, NULL, TRUE) in content_type_create(), and then clear the CCK cache directly?