Problem/Motivation

The "from" property is not always returned from a feed, which causes a PHP error

Proposed resolution

Don't assume we always are returned the "from" property - wrap in if() block

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 facebook_pull-2580501-from_not_set.patch2.31 KBcyberlily
#2 from.patch2.1 KBstefan.r
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stefan.r created an issue. See original summary.

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
FileSize
from.patch2.1 KB
cyberlily’s picture

cyberlily CreditAttribution: cyberlily commented
FileSize
facebook_pull-2580501-from_not_set.patch2.31 KB

This patch worked for me when I installed in several months ago, but it was already old enough at that point that I had to apply it manually. Just updated the module for the api fix and realized this patch wasn't included. I've created a fresh patch from the original change and the latest 7.x-3.x code. What else is needed to get this approved?

cyberlily’s picture

cyberlily CreditAttribution: cyberlily commented
Version: 7.x-2.7 » 7.x-3.2

  • daveferrara1 committed e17e9a9 on 7.x-3.x authored by cyberlily 
    Issue #2580501 by stefan.r, cyberlily: "From" property may not always be...
daveferrara1’s picture

daveferrara1 CreditAttribution: daveferrara1 commented
Version: 7.x-3.2 » 7.x-3.3
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.