Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
There are three tests for testing tax configuration components:
- Creation of tax type
- Edition of tax type
- Deletion of tax type
We're missing tests for:
- Tax rates
- Tax rate amounts
- Unexpected user input testing
Proposed resolution
Improve test coverage by creating tests for tax rates, tax rate amounts and try test unexpected user input form submissions.
Also, the tax type tests are at the moment inconsistent with existing testing structure.
Remaining tasks
- Refactor tax type tests
- Create tests for creating, editing and deleting tax rates
- Create tests for creating, editing and deleting tax rate amounts
- Improve all tests by trying unexpected user input for all editing tests
- Review
Comments
Comment #2
mglamanAdding related: #2665176: Call to a member function getRates() on null
Comment #3
bojanz CreditAttribution: bojanz at Centarro commentedNo longer relevant, since the tax module got completely rewritten, along with fresh test coverage for the plugins.
The remaining work is tracked in #2874055: Create a functional test for the Custom tax type plugin.