This module has 1 select query which is fairly slow. If a site has a read-replica (slave) then it would be good to use it. Since the data in the table is relatively static, it seems fine to always use the read replica rather than ever sending the query to the master.

CommentFileSizeAuthor
#3 2574273_send_query_read_replica_if_possible-3.patch803 bytesAohRveTPV
#2 2574273_send_query_read_replica_if_possible.patch1.26 KBgreggles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles created an issue. See original summary.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Status: Active » Needs review
FileSize
2574273_send_query_read_replica_if_possible.patch1.26 KB

I admit that I've never used this feature before, but have just read docs and copied what core does (e.g. in modules/tracker/tracker.pages.inc).

AohRveTPV’s picture

AohRveTPV CreditAttribution: AohRveTPV commented
FileSize
2574273_send_query_read_replica_if_possible-3.patch803 bytes

Remade the patch to not change modes of files.

Seems like a really good use of this feature.

If I understand correctly, it would be possible to temporarily get stale data querying the slave, but I can't think of any major problems this would cause.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented

Yes, thanks for that cleanup. Not sure what happened there.

Agreed on the impact: could return stale data, but given the nature of the data that doesn't seem like a very big risk.

lahoosascoots’s picture

lahoosascoots CreditAttribution: lahoosascoots commented

subscribing for future D8 porting reminder