Add the composer.json file

Please provide a link to some documentation on what we should add. Thanks.

@rakesh.gectcr: The patch is empty - did you need to do "git diff HEAD" instead of "git diff"?

I just need someone to confirm the accuracy of the file, then I'll commit it.

@DamienMcKenna : A good place to look at for the accuracy question is here: https://packagist.drupal-composer.org/

There you can see some requirements for contents of the file in order to get "drupal builds by composer" to work with the module.

For a complete file schema breakdown look here: https://getcomposer.org/doc/04-schema.md

----------------------------------------------------------

As you can see, the patch provided has a starting base. Take a look at the layout plugin for a comparison:

{
      "name": "drupal/layout_plugin",
      "description": "An API module to hold the Drupal 8 plugin manager for layouts.",
      "type": "drupal-module",
      "license": "GPL-2.0+",
      "keywords": ["php", "layout"],
      "homepage": "https://www.drupal.org/project/layout_plugin",
      "minimum-stability": "dev",
      "authors": [
        {
          "name": "David Snopek"
        },
        {
          "name": "Bram Goffings"
        },
        {
          "name": "Fredrik Lassen"
        }
      ],
      "require": { }
    }

I recommend that you also include in this file:

- homepage
- authors
- the minimum stability : dev (while it is not in a stable release) : this has a functional impact on composer!

[edit: removed recommendation for "type:" which I realized is in the existing patch]

this patch meets the minimum requirements for being usefull. It could use some additional optional stuff.

@jaxxed: Thanks for the tips!

Committed.

Re-opening this, the json is not valid and breaks composer_manager and therefore http://d8status.md-systems.ch.

There must not be a , after the second author.

@Berdir is correct. The json file indeed breaks composer_manager and therefore brings down the site when composer drupal-update is run again to update the dependencies.

The following composer.json file does work:

{
    "name": "drupal/metatag",
    "type": "drupal-module",
    "description": "Manage meta tags for all entities.",
    "homepage": "http://drupal.org/project/metatag",
    "license": "GPL-2.0",
    "authors": [
        {
            "name": "See contributors",
            "homepage": "https://www.drupal.org/node/640498/committers",
            "role": "Developer"
        }
    ],
    "support": {
        "issues": "http://drupal.org/project/issues/metatag"
    }
}

@rakesh.gectcr,

I would suggest adding "metatag" and "meta tag" to the keywords, but functionally it won't make a difference.

How about this?

I don't really know about the other changes, as a minimal fix, you'd just need to remove the trailing , after the second author. Can't comment on the other changes.

Btw, I've updated my d8status script for now to kill the metatag composer.json until this is fixed.

Committed.

Would it be worth doing a beta2 release to fix this?

As Beta1 breaks composer_manager, I would say yes. Otherwise users new to metatag, who pick the recommended Beta1 release, end up with a broken site.

Ok, going to do this and another issue in a new beta2.

I've just released 1.0-beta2, give it a few minutes and it'll be ready.

I added a new issue to write some tests to help make sure we (cough) don't break the file again: #2621520: Add a test to confirm the composer file is in the correct format