Date display theme functions hardcode class attribute on the HTML element which prevents theme preprocess functions from adding classes through drupal_attributes(). The current output results in two class attributes which is invalid HTML and it seems the second one will be ignored, see http://stackoverflow.com/questions/9512330/multiple-class-attributes-in-...

Propose not hardcoding class attribute, instead append it to attributes in the theme function. Patch to follow.

CommentFileSizeAuthor
#8 date-n2572213-8.patch3.06 KBDamienMcKenna
#5 date-allow-class-attribute-for-date-displays-2572213-3.patch3.01 KBfrodri
#2 date-allow-class-attribute-for-date-displays-2572213-1-7.patch3.01 KBlwalley

Issue fork date-2572213

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lwalley created an issue. See original summary.

lwalley’s picture

lwalley CreditAttribution: lwalley commented
FileSize
date-allow-class-attribute-for-date-displays-2572213-1-7.patch3.01 KB
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review

Thanks for the patch, we'll try to review it soon.

BTW when you upload a patch it helps to set the status to "needs review", that triggers the testbots and lets others know that there's something review.

Status: Needs review » Needs work

The last submitted patch, 2: date-allow-class-attribute-for-date-displays-2572213-1-7.patch, failed testing. View results

frodri’s picture

frodri CreditAttribution: frodri commented
FileSize
date-allow-class-attribute-for-date-displays-2572213-3.patch3.01 KB

Updating patch to work with version 2.10.

lwalley opened merge request !14

lwalley’s picture

lwalley CreditAttribution: lwalley commented
Status: Needs work » Needs review

Opened PR with re-roll of #5 against 7.x-2.x branch.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
date-n2572213-8.patch3.06 KB

In patch format.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed
Parent issue: » #3301877: Plan for Date 7.x-2.14

Committed. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.