There are a lot of scripts in the container directory that should be looked at to see if they are still necessary

Needed

  • containers/base/php-base/conf/scripts/start.sh
  • containers/database/mariadb-10.0/conf/startup.sh
  • containers/database/mariadb-5.5/conf/startup.sh
  • containers/database/mysql-5.5/conf/startup.sh
  • containers/database/pgsql-9.1/conf/startup.sh
  • containers/database/pgsql-9.4/conf/startup.sh

Probably needed

  • containers/base/php-base/conf/scripts/foreground.sh
  • containers/base/php-base/daemon.sh
  • containers/database/mariadb-10.0/run-client.sh
  • containers/database/mariadb-10.0/run-server.sh
  • containers/database/mariadb-10.0/stop-server.sh
  • containers/database/mariadb-5.5/run-client.sh
  • containers/database/mariadb-5.5/run-server.sh
  • containers/database/mariadb-5.5/stop-server.sh
  • containers/database/mongodb-2.6/run-client.sh
  • containers/database/mongodb-2.6/run-server.sh
  • containers/database/mongodb-2.6/stop-server.sh
  • containers/database/mysql-5.5/run-client.sh
  • containers/database/mysql-5.5/run-server.sh
  • containers/database/mysql-5.5/stop-server.sh
  • containers/database/pgsql-9.1/run-client.sh
  • containers/database/pgsql-9.1/run-server.sh
  • containers/database/pgsql-9.1/stop-server.sh
  • containers/database/pgsql-9.4/run-client.sh
  • containers/database/pgsql-9.4/run-server.sh
  • containers/database/pgsql-9.4/stop-server.sh

Probably not needed

  • containers/base/base/build.sh
  • containers/base/db-base/build.sh
  • containers/base/php-base/build.sh
  • containers/base/web-base/build.sh
  • containers/database/mariadb-10.0/build.sh
  • containers/database/mariadb-5.5/build.sh
  • containers/database/mongodb-2.6/build.sh
  • containers/database/mysql-5.5/build.sh
  • containers/database/pgsql-9.1/build.sh
  • containers/database/pgsql-9.4/build.sh
  • containers/web/web-5.3/build.sh
  • containers/web/web-5.4/build.sh
  • containers/web/web-5.5/build.sh
  • containers/web/web-5.6/build.sh
  • containers/web/web-7/build.sh
  • containers/web/run.sh

Comments

isntall created an issue. See original summary.

isntall’s picture

isntall commented
Issue summary: View changes
isntall’s picture

isntall commented
Issue summary: View changes
isntall’s picture

isntall commented
Issue summary: View changes
jthorson’s picture

jthorson commented

Needed

  • containers/base/php-base/conf/scripts/start.sh
    (This is leftover from the Szeged version, and runs the simpletest command directly. Can be removed, but the default 'CMD' for web containers should be changed to something else, such as daemon.sh.)

Probably needed

  • containers/base/php-base/conf/scripts/foreground.sh
    (jjt edit: This is leftover from the Szeged version. I expect it to eventually disappear.)
  • I'm also on the fence about the run-server.sh and stop-server.sh scripts ... in my mind, they can either stay or go.
  • I think the run-client.sh scripts should stay, as an easy way to locally connect to the db server for people who are not familiar with docker (as this gives a connection without having to know the container's IP address.)

Not needed

  • This is correct ... I think the 'build.sh' scripts, and the 'run.sh' script, can all go. We now use docker-php and the Docker Remote API to build containers.
jthorson’s picture

jthorson commented
Status: Active » Needs review

  • jthorson committed 80f2daf on 2569039-container-script-cleanup 
    Issue #2569039 by isntall, jthorson: Container script cleanup
jthorson’s picture

jthorson commented
Issue tags: +D8 Accelerate, +Barcelona2015
isntall’s picture

isntall commented
Status: Needs review » Reviewed & tested by the community
isntall’s picture

isntall commented
Status: Reviewed & tested by the community » Fixed

Merged into dev.

jthorson’s picture

jthorson commented
Status: Fixed » Reviewed & tested by the community
Issue tags: +Needs deployment
isntall’s picture

isntall commented
Assigned: Unassigned » isntall
Status: Needs work » Reviewed & tested by the community
Issue tags: +Needs deployment

There were a couple things that needed to be clean up, so this did not make it fully into production.

isntall’s picture

isntall commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs deployment

This has been merged into dev, production and is now live.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.