Closed (fixed)
Project:
Hosting
Version:
7.x-3.x-dev
Component:
Code
Priority:
Minor
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
15 Sep 2015 at 08:02 UTC
Updated:
19 Nov 2015 at 16:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
MartijnBraam commentedPlease review the patch attached.
Comment #3
helmo commentedLooks good, although maybe the default should just be 'info'
Comment #5
helmo commentedCommited.
I also updated the default to info and satisfied the coder module.
A few remarks from the coder module:
Comment #7
gboudrias commentedComment #8
ergonlogicWhile I get the reasoning here, I don't know that this is actually a good idea. FWIW, this was how I'd initially implemented this message. The problem is that we're flagging a non-warning or non-error entry as such. I think this is actually misleading.
We have jump links that get you to the first relevant warning or error. I don't know what this would provide.
Sorry for commenting after the fact.
Comment #9
helmo commentedI think it's nice that it matches the overall result of a task.
But I agree with @ergonlogic that the line itself is not an error. And it could also be confusing if someone were to gather statistics on the number of errors.
So I don't object to reverting this.
Comment #11
helmo commentedI've reverted this ... sorry @MartijnBraam