Problem/Motivation

While I was dealing with #2560231: Replace a class in forum-list.html.twig with a BEM class. I noticed that all but the first cell of the forum list table use the .forum__[element] naming convention. The first cell has the class .forum-list__forum which differs from its siblings naming pattern.

Proposed resolution

Add the .forum__info class to Classy's template to replace .forum-list__forum . Check that no other CSS exists styles the forum name with the current selector in HEAD.

Remaining tasks

User interface changes

none

API changes

none

Data model changes

none

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it does not creates visual issues.
Issue priority Not critical because the forum functions fine.
Unfrozen changes Unfrozen because it only changes markup
Prioritized changes The main goal of this issue is to make coherent the class names of a component in Core.
Disruption Non-disruptive it fixes a DX issue.
Files: 
CommentFileSizeAuthor
#11 2568457-11.patch1.05 KBVidushi Mehta
#8 screenshot-2015-09-21 14-19-14.png155.47 KBthamas
#3 replace-class-2568457-3.patch585 bytesthamas
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 112,998 pass(es). View

Comments

thamas created an issue. See original summary.

thamas’s picture

Issue summary: View changes
thamas’s picture

FileSize
585 bytes
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 112,998 pass(es). View

Here is the patch.

thamas’s picture

Status: Active » Needs review
thamas’s picture

I did not find any CSS that themes the forum with the current class of .forum-list__forum anywhere in Core.

csakiistvan’s picture

It works, thx

LewisNyman’s picture

Status: Needs review » Needs work

I'm not sure about this, because the this element doesn't contain the forum info. It contains the entire forum. Is that right? That's why it's described as a forum inside a forum-list

thamas’s picture

@LewisNyman The element is the first cell in a table row in which all cells contain information about the same forum. The cells ar siblings in html and their content also related. The only difference that the first cell has some divs in it. These are the icon, the name and the discription of the forum which is information about the forum--this is the source of my name suggestion. Of course the other cells also contain info about the forum so if you have a better name suggestion feel free to add it.

Otherwise the tr and table elements have different names also so we could have a longer discussion about if we have only one component with elements inside it or we have a component with other components in it.

Drupal 8 forum screenshot

I'm sure that the current naming is not OK.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Vidushi Mehta’s picture

Adding a patch

Vidushi Mehta’s picture

Status: Needs work » Needs review

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.