Database name with hyphen clash with service definition "renderer" does not exist

Hi,

The database name is sanitized in the createDatabase() function (in core/lib/Drupal/Core/Database/Driver/mysql/Connection.php) by the use of :

    $database = Database::getConnection()->escapeDatabase($database);

This function forces all database names to be strictly alphanumeric-plus-underscore. I'm sure there are great motivations for that (be generic for all the DB drivers?) but this means we need to do the same operation on the database name stored in the settings.php

@hass, sorry for the summary, it was a mistake.

I don't either like the idea of saving modified names, but does it make sens to have a db name in Mysql called "drupal8qatest" and "drupal8-qa-test" in settings.php ?

An other solution could be to modify values when loading info from settings.php. This needs to be catched in order to avoid doing the regex all the time, but I'm not fan of that too.

Maybe the easiest solution is to simply create a form validate on the DB name field to inform users they can't use hyphens in DB names ?

Sitting here at Drupalcon and this is still an issue. Just FYI. Dashes in the DB name crash D8. I installed from Drush with no problem but loading the site is a WSOD.

Regarding MySQL documentation dash are allowed but database names need to be wrapped in-between quotes. By default, MySQL allow underscore

Basically:

    Permitted characters in unquoted identifiers:
    ASCII: [0-9,a-z,A-Z$_]
    Extended: U+0080 .. U+FFFF

    Permitted characters in quoted identifiers:
    ASCII: U+0001 .. U+007F
    Extended: U+0080 .. U+FFFF

There are several problems we need to solve:
1) We need to describe on the Database Name field that not all characters are allowed (names must be strictly alphanumeric-plus-underscore).
2) Add a field validate to avoid the form be submitted.
3) Updating the function that write db settings to settings.php to use the DB clean up database name.

Notes :
- The form construction is done by getFormOptions() in core/lib/Drupal/Core/Database/Install/Tasks.php
- The escape database function escapeDatabase() is located in core/lib/Drupal/Core/Database/Connection.php

Should the title be updated to reflect the real underlying issue?

Closing the issue because an older one is already existing #2443839

I have summarized patches and conversations over there