Move theme quickedit CSS to the Seven theme

Here is patch. Added screenshots how quick edit looks when admin theme is Seven and when is Stark.

Patch #2 applies, get the same result.

First patch didn't applied anymore, because of changes in seven.info.yml file. Patch and interdiff added.

Reroling a patch

anybody have any idea, why it fails. I mean patch applied on my local sucessfully but automated test failed to apply :(

@Manjit.Singth: you rolled it against 8.1, but tested against 8.0.

oppsss :( Now queued for 8.1 .. let see what happened.

1. +++ b/core/modules/quickedit/quickedit.module
   @@ -64,7 +64,7 @@ function quickedit_page_attachments(array &$page) {
   + * The CSS files can be specified via the "quickedit_stylesheets" property in the
   

   80 chars limit

2. +++ b/core/modules/quickedit/quickedit.module
   @@ -85,7 +85,8 @@ function quickedit_library_info_alter(&$libraries, $extension) {
              foreach ($info['quickedit_stylesheets'] as $path) {
   -            $library['css']['theme']['/' . $theme_path . '/' . $path] = [];
   +            // Ensure it overrides any styling from the frontend theme.
   +            $library['css']['theme']['/' . $theme_path . '/' . $path] = ['weight' => 20 ];
   

   Themes should use library override for that

Adding tags

Patch looks good.
But there is this transition when moving from one component to another which IMHO is unnecessary.

Loader/spinner is not working when we are saving any content. Please check the screencast for better understanding.

@Manjit.Singh: Thanks for your manual testing! Great find :) (Also, wow, your computer is very slow, or more likely: you have Xdebug enabled.)

This clearly needs work for #21.

The loader file doesn't exist within the images folder for the seven theme and hence does not load.

I have a doubt, why are we loading the image from the theme's images folder instead of quickedit module's image folder?

Patch using spinner image from quickedit module image folder.
Tested in local environment.

+++ b/core/themes/seven/css/components/quickedit.icons.css
@@ -0,0 +1,74 @@
+.quickedit .icon-throbber:before {
+  background-image: url(../../../../modules/quickedit/images/icon-throbber.gif);
+}

Initially, when we hit save button, it turns into Gray and icon-throbber is made according to that. but now we have change the design of button after hitting. So i guess we have to update icon-throbber.gif file also.

@Wim any thoughts ?

I think we should either:

1. move that throbber image into Seven too, or
2. keep the CSS that loads the throbber in Quick Edit, because as the IS says: module CSS [is defined] as: “the minimal styles needed to get the module's functionality working.”, and this is then module CSS that themes can override

I think we should go with option 2 and put throbber css in quickedit module.
otherwise every theme will need to have a copy of throbber gif which is just redundant.

Agreed!

+++ b/core/modules/quickedit/quickedit.module
@@ -85,7 +85,8 @@ function quickedit_library_info_alter(&$libraries, $extension) {
         }
         if (isset($info['quickedit_stylesheets'])) {
           foreach ($info['quickedit_stylesheets'] as $path) {
-            $library['css']['theme']['/' . $theme_path . '/' . $path] = [];
+            // Ensure it overrides any styling from the frontend theme.
+            $library['css']['theme']['/' . $theme_path . '/' . $path] = ['weight' => 20 ];
           }

This is a useful patch but I'm concerned about where we are putting the CSS. It's by no means a given that the user wants 'admin things' on the front end to match the administrative theme. I'd argue that they are two different things and that it's possible that we need a separate library for all of these things that is *not* Seven theme. I discussed this with Laurii in Dublin and I think he feels the same way.

I wrote a bit longer comment about my concerns a year ago here. I think it's a great idea to move design decisions away from modules but I don't believe the right solution is to move them to an admin theme. We need something a little more abstract so that we don't end up having scalability issues with contrib.

We need something a little more abstract so that we don't end up having scalability issues with contrib.

I totally agree. Feels like it should be a library and not in any theme.

Per #32 and #33.