Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

kyuubi’s picture

Hi,

Just pitching in a bit here in terms of requirements.

I think the main thing is to provide an interface in metatag, same as we have in D7, where site managers can specify metatags based on a url.

The main use case for this is typically around things like views or custom pages, that site managers can't edit as they do nodes, but they still want to control the metadata on them.

I think the interface approach in D7 worked like a charm for this.

Hope this helps, do you have any plans on when we could expect a first release?

Thanks,

DamienMcKenna’s picture

I have no idea when I'll get to this, it certainly won't be until after 1.0.

kyuubi’s picture

Hi Damien,

I understand. Is there any workaround you know of until this gets sorted?

Thanks in advance,

DamienMcKenna’s picture

Not really..

DamienMcKenna’s picture

Category: Task » Feature request
Status: Active » Postponed

Will get to this after 1.0.

DamienMcKenna’s picture

Status: Postponed » Active

8.x-1.0 is out, so this is fair game again.

kyuubi’s picture

Hi Damien,

That's fantastic, I think it's a much needed requirement.

Cheers,

jansete’s picture

In 7 version this was in Metatag: context submodule, any plans for this feature?

kyuubi’s picture

Hi guys,
Any news on this front?

iancawthorne’s picture

I think this module covers this functionality:
https://www.drupal.org/project/context_metadata

There is a ticket open to merge it into being a sub module of Metatag here:
https://www.drupal.org/node/1498754

context_metadata is great for consistency from my point of view, as I'm also using context_active_trail which uses the same UI.

DamienMcKenna’s picture

context_metadata would have to be rewritten to use Metatag's APIs, right now it does its own thing.

DamienMcKenna’s picture

FYI I just saw this module show up: https://www.drupal.org/project/metatag_routes

Nice!

asarafraz’s picture

This is an important feature and is highly needed for page--path.html.twig templates. On these pages, it currently shows "page not found" as the page title which would be great to replace it with a meaningful title. I'm surprised that drupal core doesn't provide such feature for page--path templates (or maybe there is such a way but I was not able to find it, please let me know if there is such a way to set the page title in the drupal core for page--path.html.twig templates).

@DamienMcKenna are you suggesting that we should use metatag_routes module or do you plan to integrate it into the metatag module? It seems like the metatag_routes is a great module but I personally prefer to use modules that are covered by Drupal's security advisory policy (it is not covered at the moment). Thank you!

jansete’s picture

Any news or plan about this feature?

jansete’s picture

How can we help merge https://www.drupal.org/project/metatag_routes or https://www.drupal.org/project/context_metadata to get this behaviour in this module?

jcnventura’s picture

@DamienMcKenna, I wonder if ever since #3000624: Provide support for all supported metatags (commit at https://git.drupalcode.org/project/context_metadata/commit/52d05ca8fff88...), your comment in #13 about context_metadata doing it's own thing still applies.

dbouman’s picture

+1

Any update on this feature? It would be very useful.

Or are you suggesting we use the https://www.drupal.org/project/metatag_routes module for this functionality?

DamienMcKenna’s picture

I'm talking about adding https://www.drupal.org/project/metatag_routes to the main Metatag module.

DamienMcKenna’s picture

Issue summary: View changes
DamienMcKenna’s picture

It might be worth merging the functionality into the main module instead of just adding it as a separate module.

Anybody’s picture

Great idea @DamienMcKenna, just found this issue while I was also searching for a way to set the user/login page to noindex! Same as #3049796: [PP-1] User/login and user/register pages default metatags

So I can say +1 for integrating that contrib module as submodule. Would be nice if that wouldn't be needed extra anymore. I'll ping the maintainer @waldomero :)

joao.ramos.costa’s picture

I'd say +1 to integrate that contrib module. It would be very useful IMO.

DamienMcKenna’s picture

Status: Active » Needs review
FileSize
9.89 KB

This provides a copy of the Metatag Routes module with some slight tidying of the codebase.

DamienMcKenna’s picture

Some changes after some manual testing.

Status: Needs review » Needs work

The last submitted patch, 26: metatag-n2563655-26.patch, failed testing. View results

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
9.94 KB

Fixed the README.md file.

DamienMcKenna’s picture

Title: Per-path configurations » Per-path configurations, absorb Metatag Routes module

Should we add this to composer.json?

  "conflict": {
    "drush/metatag_routes": "*"
  }

The idea is that it would prevent sites from downloading metatag_routes using Composer, but might it prevent existing sites from updating to this release of Metatag if they already have Metatag Routes installed?

DamienMcKenna’s picture

I think we should add this to Metatag 2.0, which will give us time to improve the UI and add tests.

DamienMcKenna’s picture

Or we'll just add it now and improve it as we go.

DamienMcKenna’s picture

Adding credit to waldomero for all his great work.

DamienMcKenna’s picture

Title: Per-path configurations, absorb Metatag Routes module » Absorb Metatag Routes module to allow per-path/route configurations
Status: Needs review » Fixed

Committed. Woot!

Anybody’s picture

Hey Damien, just wanted to say THANK YOU SO MUCH for adding this! Another big step for Metatags and a really great improvement. Thanks for your time invested here for all of us!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.