Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna’s picture

DamienMcKenna’s picture

While working on this I discovered that the DrupalConsole commands didn't work right, so.. #2663650: Fix the DrupalConsole tag generator

DamienMcKenna’s picture

WIP - this moves the existing group and tags into a new metatag_open_graph module, and then adds og:image:width, og:image:height, og:image:type and og:determiner.

DamienMcKenna’s picture

Oh, wait, og:determiner hasn't been added yet because the generator is still failing.

DamienMcKenna’s picture

Status: Needs review » Needs work

The last submitted patch, 5: metatag-n2563623-5.patch, failed testing.

The last submitted patch, 5: metatag-n2563623-5.patch, failed testing.

DamienMcKenna’s picture

This fixes the two tests and adds og:determiner.

DamienMcKenna’s picture

This adds the appropriate 'use' statement for the base class, adds an update script to enable the new module, fixes og:image:height, and updates the generator template as necessary.

DamienMcKenna’s picture

Status: Needs review » Needs work

The last submitted patch, 12: metatag-n2563623-12.patch, failed testing.

The last submitted patch, 12: metatag-n2563623-12.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
26.94 KB

I committed the whitespace change to generator.php.twig separately.

  • DamienMcKenna committed 0d7e654 on
    Issue #2563623 by DamienMcKenna: Moved OG tags to new submodule, added...
DamienMcKenna’s picture

Title: Add all of the OpenGraph meta tags to 8.x-1.x » Add the main OpenGraph meta tags to 8.x-1.x
Status: Needs review » Fixed

I'm going with these, we'll follow up later to add the rest, and some tests.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

achton’s picture

After this change, I get an InfoParserException: Unable to parse sites/storebaelt/modules/contrib/metatag/metatag_open_graph/metatag_open_graph.info.yml A colon cannot be used in an unquoted mapping value at line 1 (near "name: Metatag: Open Graph").

DamienMcKenna’s picture

Status: Closed (fixed) » Needs review
FileSize
408 bytes

Whoops. Does this fix it?

DamienMcKenna’s picture

achton: Where do you see the error message? I'm having a hard time triggering it.

  • DamienMcKenna committed 0829317 on 8.x-1.x
    Issue #2563623 by DamienMcKenna, achton: Quote submodule strings to...
DamienMcKenna’s picture

Status: Needs review » Fixed

Per the D8 documentation, the syntax should be ok, but I'm committing the change anyway.

  • DamienMcKenna committed 038a61b on 8.x-1.x
    Issue #2563623/2674732/2675208 by DamienMcKenna, esclapes, NickWilde,...
  • DamienMcKenna committed 74376bc on 8.x-1.x
    Issue #2563623/2674732 by DamienMcKenna, esclapes, achton: Quote...
achton’s picture

Apologies for the late reply Damien.
I initially saw the error on the /admin/modules page. I did not have any Metatag modules enabled at the time.

Sadly, I have since been unable to reproduce this :-(

Anyway, I think the fix is correct, since the docs also state:

Use quotes if your value includes special indicators, such as a colon (:) followed by a space or a newline

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jcisio’s picture

Issue summary: View changes

For future reference, it's because of Symfony Yaml 3.0+ https://github.com/symfony/yaml/blob/master/CHANGELOG.md. Drupal is currently shipped with Yaml 2.8 so no problem unless you also have Yaml 3.0+ in your project.

Yaml 3.0+ may be found in Drush (e.g. the .phar version) https://github.com/drush-ops/drush/commit/5ae80f8c85d4792eab88b9b03deb03...

DamienMcKenna’s picture

Thanks for the clarification!