Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Unable to parse ... A colon cannot be used in an unquoted mapping value
Add all of the OpenGraph meta tags from the D7 branch to the 8.x-1.x branch. May need to split out the meta tags into submodules after all.
Comment | File | Size | Author |
---|---|---|---|
#20 | metatag-n2563623-20.patch | 408 bytes | DamienMcKenna |
#15 | metatag-n2563623-15.patch | 26.94 KB | DamienMcKenna |
Comments
Comment #2
DamienMcKennaComment #3
DamienMcKennaIn order to make sure #2656494: Make meta tag configurations translatable in D8 works, I'm going to do this for beta4.
Comment #4
DamienMcKennaWhile working on this I discovered that the DrupalConsole commands didn't work right, so.. #2663650: Fix the DrupalConsole tag generator
Comment #5
DamienMcKennaWIP - this moves the existing group and tags into a new metatag_open_graph module, and then adds og:image:width, og:image:height, og:image:type and og:determiner.
Comment #6
DamienMcKennaOh, wait, og:determiner hasn't been added yet because the generator is still failing.
Comment #7
DamienMcKennaComment #10
DamienMcKennaThis fixes the two tests and adds og:determiner.
Comment #11
DamienMcKennaThis adds the appropriate 'use' statement for the base class, adds an update script to enable the new module, fixes og:image:height, and updates the generator template as necessary.
Comment #12
DamienMcKennaThis adds a bunch more og meta tags.
Comment #15
DamienMcKennaI committed the whitespace change to generator.php.twig separately.
Comment #17
DamienMcKennaI'm going with these, we'll follow up later to add the rest, and some tests.
Comment #19
achtonAfter this change, I get an InfoParserException:
Unable to parse sites/storebaelt/modules/contrib/metatag/metatag_open_graph/metatag_open_graph.info.yml A colon cannot be used in an unquoted mapping value at line 1 (near "name: Metatag: Open Graph").
Comment #20
DamienMcKennaWhoops. Does this fix it?
Comment #21
DamienMcKennaachton: Where do you see the error message? I'm having a hard time triggering it.
Comment #23
DamienMcKennaPer the D8 documentation, the syntax should be ok, but I'm committing the change anyway.
Comment #25
achtonApologies for the late reply Damien.
I initially saw the error on the /admin/modules page. I did not have any Metatag modules enabled at the time.
Sadly, I have since been unable to reproduce this :-(
Anyway, I think the fix is correct, since the docs also state:
Comment #27
jcisio CreditAttribution: jcisio at Axess Open Web Services for ARTE G.E.I.E. commentedFor future reference, it's because of Symfony Yaml 3.0+ https://github.com/symfony/yaml/blob/master/CHANGELOG.md. Drupal is currently shipped with Yaml 2.8 so no problem unless you also have Yaml 3.0+ in your project.
Yaml 3.0+ may be found in Drush (e.g. the .phar version) https://github.com/drush-ops/drush/commit/5ae80f8c85d4792eab88b9b03deb03...
Comment #28
DamienMcKennaThanks for the clarification!