I noticed the following bug: I exported an entityform with features and when reverting the feature the default submission view for that entityform changes back to default no matter what we have in code already and in the back-office the entityform will be shown as overriden if I change the submission view to something else than 'Use default'.

CommentFileSizeAuthor
#2 2563299-2.patch732 byteslhangea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lhangea created an issue. See original summary.

lhangea’s picture

FileSize
732 bytes

I looked in code a little bit and in the .module file I noticed that in the 'create' method of EntityformTypeController if the 'is_new' flag is set the 'submissions_view' and ''user_submissions_view' are set back to 'default' loosing what we have in feature. I provide a quick patch which fixes the issue but please someone which knows the module better take a look also and see if the problem doesn't reside in another place in fact.

lhangea’s picture

Assigned: lhangea » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2563299-2.patch, failed testing.

tedbow’s picture

@lhangea I think the version is wrong for this issue so the patch doesn't apply.

are you working against 7.x-1.x or 7.x-2.x?

Thanks

lhangea’s picture

Version: 7.x-1.0-rc1 » 7.x-2.0-rc1
Status: Needs work » Needs review

Yes, the version was wrong.

lhangea queued 2: 2563299-2.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2: 2563299-2.patch, failed testing.

lhangea’s picture

Interesting because on my local environment the tests pass just fine. Are the tests run against 7.x-2.x or 7.x-2.0-rc1 ?

tedbow’s picture

Version: 7.x-2.0-rc1 » 7.x-2.x-dev
Status: Needs work » Needs review

@lhangea the tests will be run against the version that is set in this issue.

I am switching it now from 7.x-2.0-rc1 to 7.x-2.x-dev

I will retest.

tedbow queued 2: 2563299-2.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2: 2563299-2.patch, failed testing.

sokru’s picture

Status: Needs work » Closed (duplicate)

This works in latest dev, but not in stable release. I assume https://www.drupal.org/node/2408765 resolved this.