Inject string translation service into ForumBreadcrumbBuilderBase

Moving to 8.2.x since this is a code change.

Patch applies, oddly enough. :-)

Re-running the testbot to see if it still works.

Just one thing to review at the moment:

+++ b/core/modules/forum/src/Breadcrumb/ForumBreadcrumbBuilderBase.php
@@ -55,11 +56,14 @@
+    $this->stringTranslation = $string_translation;

StringTranslationTrait has setStringTranslation(), which we should use.

Cool, thanks.

Addressed #6, patch applies, tests are green.

There's still this kind of thing:

+++ b/core/modules/forum/tests/src/Unit/Breadcrumb/ForumBreadcrumbBuilderBaseTest.php
@@ -42,6 +42,7 @@ public function testConstructor() {
+    $translation_manager = $this->getMock('Drupal\Core\StringTranslation\TranslationInterface');

It'd be nice to use TranslationInterface::class instead of the literal string, but then it would be different from all the other mocks in the test. So favoring consistency let's RTBC. Maintainers can of course disagree and send it back.

Drupal\Core\Database\DatabaseExceptionWrapper: Exception in test_field_field_complex_test[test_field_field_complex_test]: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'jenkins_default_155622.simpletest113246entity_test' doesn't exist: SELECT entity_test.id AS entity_test_id, entity_test.id AS id, users_field_data_entity_test.uid AS users_field_data_entity_test_uid
FROM 
{entity_test} entity_test
LEFT JOIN {users_field_data} users_field_data_entity_test ON entity_test.user_id = users_field_data_entity_test.uid
ORDER BY entity_test_id ASC
LIMIT 11 OFFSET 0; Array
(
)

Looks like something was wrong with this DrupalCI instance. Re-testing.

I think it's OK to do the test changes later.

Committed 0745511 and pushed to 8.2.x. Thanks!