Problem/Motivation

As per trait StringTranslationTrait the string translation service should be injected if possible.

StringTranslationTrait uses \Drupal to find the service if it's not available, but we should specify it explicitly.

Proposed resolution

Explicitly inject the string translation service into BookBreadcrumbBuilder::__construct() as part of the inversion of control pattern.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 inject_string_translation_service-2562645-6.patch1.73 KBmorenstrat
#2 inject_string_translation_service-2562645-1.patch1.88 KBmorenstrat
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dunix created an issue. See original summary.

morenstrat’s picture

morenstrat
he/him
Primary language German
Location Bochum, Germany
CreditAttribution: morenstrat commented
FileSize
inject_string_translation_service-2562645-1.patch1.88 KB
morenstrat’s picture

morenstrat
he/him
Primary language German
Location Bochum, Germany
CreditAttribution: morenstrat commented
Status: Active » Needs review

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Version: 8.1.x-dev » 8.2.x-dev
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs reroll

Bumping to 8.2.x since it's a code change.

If there's not already a string translation service in the class property, StringTranslationTrait will use \Drupal to discover it, but we should supply it explicitly. So yay this issue does the right thing. Except for this:

+++ b/core/modules/book/src/BookBreadcrumbBuilder.php
@@ -53,11 +54,14 @@ class BookBreadcrumbBuilder implements BreadcrumbBuilderInterface {
+    $this->stringTranslation = $string_translation;

StringTranslationTrait has the setStringTranslation() method which we should use.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Parent issue: » #2729597: [meta] Replace \Drupal with injected services where appropriate in core
morenstrat’s picture

morenstrat
he/him
Primary language German
Location Bochum, Germany
CreditAttribution: morenstrat commented
Status: Needs work » Needs review
FileSize
inject_string_translation_service-2562645-6.patch1.73 KB

Updated patch using $this->setStringTranslation().

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

Makes the changes from #5, patch applies, tests are green, let's do it. :-)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: inject_string_translation_service-2562645-6.patch, failed testing.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs work » Reviewed & tested by the community

I can't repro the fail locally. It's our old pal Drupal\migrate_drupal_ui\Tests\d6\MigrateUpgrade6Test.

Setting to RTBC.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Priority: Normal » Minor

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: inject_string_translation_service-2562645-6.patch, failed testing.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs work » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: inject_string_translation_service-2562645-6.patch, failed testing.

The last submitted patch, 7: inject_string_translation_service-2562645-6.patch, failed testing.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs work » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: inject_string_translation_service-2562645-6.patch, failed testing.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs work » Reviewed & tested by the community
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Postponed

Postponing as per #2729625-20: Inject services into BookAdminEditForm. Let's explore a little to see if we can find out a way to scope these that is not one controller at a time. Thanks!

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented

This extension is being deprecated, see #3376070: [Meta] Tasks to deprecate Book module. It will be removed from core and moved to a contrib project, #3376101: [11.x] [Meta] Tasks to remove Book.

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

This issue may be re-opened if it can be considered critical, If unsure, re-open the issue and ask in a comment.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Postponed » Closed (outdated)
Related issues: +#2470896: Make Book navigation translatable

I think this was fixed by #2470896: Make Book navigation translatable. Therefor closing as outdated