How to reproduce:
* Have a server with imagemagick installed on the system path (so seems not to need a special setting)
* generate image

=> error: Unable to generate the derived image

What makes this error really nasty (thus raising prio):
* Saving the image toolkit settings at admin/config/media/image-toolkit makes the error not reproducible any more.

This really shot me in the knee, because after every deployment on a new server, it errored out, but while debugging it went away.

Debugging showed it's just inconsistent use of variable get:

* in image_imagemagick_settings():

    '#default_value' => variable_get('imagemagick_convert', 'convert'),

* in _imagemagick_convert_exec():

    $convert_path = variable_get('imagemagick_convert', NULL);
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

axel.rutz created an issue. See original summary.

geek-merlin’s picture

Status: Active » Needs review
FileSize
948 bytes

Trivial patch flying in that fixes the issue for me.

geek-merlin’s picture

This patch also removes the now obsoleted comment.
I think what made sense years ago is not the best in a world of automated deployment.

ciss’s picture

Status: Needs review » Reviewed & tested by the community

Agreed. A user opening the settings form assumes that convert is set as command, even when it isn't, and the default seems sensible.

#3 is ready to go.

Chris Charlton’s picture

Bump. :)

Anybody’s picture

Confirming RTBC. A new stable relase could use several RTBC'd patches. Active maintainer?

Chris Charlton’s picture

+1

Re: Maintainer -- last commit was by 'mondrake' about a month ago. Hoping this can go up soon.

mondrake’s picture

Sorry folks I only maintain the 8.x branches, see the project page and #1802534-23: ImageMagick scale breaks animated gifs.

The 7.x branch has had no commits for 5 years and surely needs some love.

Chris Charlton’s picture

@mondrake, I can help manage the D7 branch for this calendar year. Please hook it up and I'll move these tickets forward.

mondrake’s picture

@Chris Charlton great to hear that!

I can't give you access as I am a co-maintainer myself, with no rights to the Maintainers section of this project. Just file a request in Drupal.org project ownership issue queue. That's what I did in #2558165: Offering to maintain a 8.x-1.x branch of ImageMagick.

Chris Charlton’s picture