Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.If a user lacks the "community" role the content created gets checked by Mollom and depending on certain criteria published or unpublished. Given that any link to a legit drupal.org ressource (project, api etc) and outside sources is highly likely to trigger Mollom to not publish a comment we need to make sure that users know about this and know what they can do. Currently we are displaying this message after somebody comments in the issue queue and Mollom unpublished the comment:
Issue [ISSUE TITLE] has been updated.
There is no indication that the post is unpublished and queued for review.
This message needs to make clear that the comment was succesfully created but also that it is not published until it is reviewed. It should also include a hint about the community role and how to get it, like we display upon node creation by new users.
Implementation
Message to show:
todo
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | do message.PNG | 38.67 KB | dddave |
| #3 | unpublished-comments.png | 43.87 KB | joshuami |
| dotest4 repost success little indication of unpublished.PNG | 37.73 KB | dddave |
Comments
Comment #2
dddave CreditAttribution: dddave commentedWhy this is important? Check how often these legit users tried to communicate in an issue: https://www.drupal.org/user/3157081/admin-content and https://www.drupal.org/user/3344660/admin-content.
This is no way to greet new community members.
Comment #3
joshuamiWow. I agree that queue needs some review. For the short term, I'll see if we can free up some time from @b_man to review this daily.
We have some additional spam prevention work planned for next week that may give us a better option that Honeypot and Mollom for blocking spammy comments. We don't get a ton of false positives, but when we do they are often from people who really need help.
On a related now, I see a possible bug on some of these unpublished comments. In #1677026: Less aggressive locale js file rebuilds, which was linked from the comment approval queue, both catch and Gábor Hojtsy have unpublished comments... that doesn't seem correct.
Comment #4
joshuamiComment #5
dddave CreditAttribution: dddave commentedI quite often see unpublished comments in core issues by very prominent users. I always assumed they manually unpublished botchy patch comments or some such but never investigated.
Comment #6
drummYep, we don't really know all the reasons comments get unpublished, it isn't just spam. For example, I learned that sometimes System message's old PIFT comments are sometimes unpublished to shorten scrolling/reading time for issues.
Comment #7
drummI’m adding an implementation section to the issue summary to fill out. Please move this issue back to active when drafted well.
When should this be shown? “Your comment has been queued for review…” is shown when a new comment is posted as unpublished. Is that okay.
The existing message is from core and is not easily overridable. Easiest option would be to display another message afterward. If that is too awkward, I expect hijacking l10n to change it would be doable.
Comment #8
dddave CreditAttribution: dddave commentedYes. We could think about making the message a bit more flashy because I feel like a lot of users tend to overlook/ignore it.
I think that would be fine. Can't we recycle the message we show upon node creation I screenshot in the OP? "As part of our (...) make your request."
Comment #9
dddave CreditAttribution: dddave commentedAdded a pretty drastic example. Had another more legit user hitting this wall multiple times in an translation issue but forget to screegrab.
Comment #10
dddave CreditAttribution: dddave commentedAnother user bites the dust (one comment approved by me afterwards): https://www.drupal.org/node/2693251
Comment #11
dddave CreditAttribution: dddave commentedhttps://www.drupal.org/node/1458824#comment-11048725 triggered me to re-test how we handle comments and it seems we have changed something since the last time I tested. I'll update the issue summary and set this back to active. The current messaging is much worse than in the first draft of this issue.
Comment #12
dddave CreditAttribution: dddave commentedComment #13
dddave CreditAttribution: dddave commentedLet's make that specifically about issue queue comments. Comments in forums are handled much differently (and better) it seems.
edit: did some testing and the main issue are issue queue comment because their message is completly out-of-whack. When I trigger Mollom in the Forums I get an adequate message "there has been a problem... try again after 60 seconds...to complete this form..." but I was not able to get this response in the issue queue. Instead Mollom "silently" unpublishes as described in the summary. Why don't we get the same message here?
Comment #14
dddave CreditAttribution: dddave commentedComment #15
drummThe time limits aren't Mollom, that's honeypot module. I wouldn't be surprised if we haven't gotten honeypot working on issue queues.
It is possible to get a comment through honeypot, but not Mollom, in the forums, and be in the same situation.
Comment #16
dddave CreditAttribution: dddave commentedSeeing this almost daily, especially when newbies post code in issues to contribute. Do I understand #15 correctly that Mollom is the culprit here silently unpublishing or am I mistaken? The situation would be massively improved if there would be any feedback at all that a post is unpublished.
Comment #17
drummYes, Mollom, and admins manually unpublishing, are the only ways I can think of offhand for a user’s comment to be unpublished. If Mollom thinks a post is spam, it will unpublish it.
Looks like #8 has implementation details, which I had managed to miss.
Comment #18
drummI committed a fix for this to the project's dev branch. I expect it to be deployed in the next couple days.
Comment #20
drummThis has been deployed.
Comment #21
dddave CreditAttribution: dddave commentedGreat. Let's see if this reduces the number of newbies posting the same content three or for times.