Part of #2557113: Make t() return a TranslationWrapper object to remove reliance on a static, unpredictable safe list

In #2557113: Make t() return a TranslationWrapper object to remove reliance on a static, unpredictable safe list these were returning SafeStringInterface objects which resulted in test failures. These strings don't really need to be wrapped in t().

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it improves tests
Issue priority Major because it is a split off an existing major
Unfrozen changes Unfrozen because it only changes tests.
CommentFileSizeAuthor
#2 2560733-2.patch4.53 KBstefan.r

Comments

stefan.r created an issue. See original summary.

stefan.r’s picture

stefan.r commented
Status: Active » Needs review
StatusFileSize
new 2560733-2.patch4.53 KB
stefan.r’s picture

stefan.r commented
Priority: Normal » Major
Issue summary: View changes

Upgrading to major as these were split out of a Major issue

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: Remove a few unnecessary t() calls » Remove a few unnecessary t() calls from tests
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

This looks good to go. I added a beta evaluation.

stefan.r’s picture

stefan.r commented
Title: Remove a few unnecessary t() calls from tests » Remove a few problematic t() calls from tests

Thanks! Just updating title to reflect these are not just a few unnecessary t()s (which we already have an issue for). These were actually breaking things in the parent.

stefan.r’s picture

stefan.r commented
Parent issue: » #2557113: Make t() return a TranslationWrapper object to remove reliance on a static, unpredictable safe list
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Test only change - beta permitted. Committed c5d6d65 and pushed to 8.0.x. Thanks!

  • alexpott committed c5d6d65 on 8.0.x 
    Issue #2560733 by stefan.r: Remove a few problematic t() calls from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.