I can't think of a reason for the free / % off shipping offers to require a shipping service argument. They should be optionally available to any shipping service available for an order.

CommentFileSizeAuthor
#11 Screen Shot 2017-03-28 at 4.37.49 PM.JPG277.18 KBtophneal
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rszrama created an issue. See original summary.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented

Second this:) Will likely work on this implementation.

rszrama’s picture

rszrama CreditAttribution: rszrama commented

Do you think it's worth pursuing multi-select as well?

rszrama’s picture

rszrama CreditAttribution: rszrama commented
Title: Allow the abstract shipping offers (free / % off) to apply to any shipping service » Allow free shipping to apply to any shipping service

Oh, hey. "% off shipping" actually supports an optional shipping service designation, so you could technically offer free shipping via 100% off any shipping service. We should duplicate the functionality for the "Free shipping" offer so long as we have it, I suppose.

rszrama’s picture

rszrama CreditAttribution: rszrama commented

Interesting side note: the action to manage a % off discount on shipping indicates it should get a third argument, but it never actually gets set in the build phase. I think it should probably be removed. No clue why we need to be passing shipping service names to this or free shipping considering we can access the target shipping services from the discount entity anyways.

rszrama’s picture

rszrama CreditAttribution: rszrama commented

The patch for this issue should be dependent on #2560773: Add support for "Free or reduced shipping" offers, as that one fixes the free shipping action callback to make proper use of the price API (and removes the unnecessary service_name parameter). Note that in the event we should make all shipping services free, you'll skip the part where the discount strategy is evaluated.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented

Multi-select also sounds great because you may only want to choose your ground shipping and you use UPS and FEDEX depending on their location(because UPS may give better rates to X location)

rszrama’s picture

rszrama CreditAttribution: rszrama commented

Yeah, I almost went ahead and converted the action to always use an array to determine which shipping services to reduce, even though it was only a single value option for now to better prepare it for the future. But then I realized I was over engineering that patch and left it for this issue. ; )

torgosPizza’s picture

torgosPizza
he/him
Primary language English
Location Portland, OR
CreditAttribution: torgosPizza commented

I would love this too.

However, I can't get any of the free or reduced shipping discounts to work - shipping still appears as an added line item despite the presence of the order.

Screenshot: https://www.dropbox.com/s/mnf989hq7zmgjcl/Screenshot%202015-12-09%2009.0...

At this point I just have to disable the rule that collects rates to offer free shipping, but ideally we'd get this working. I'll look into this more and will open a new issue since I appear to be the only one affected (or no one else is attempting to use the Free shipping discount!)

EDIT: I was able to accomplish this just by creating a new free shipping calculation rule in the Shipping settings, and setting the shipping line item price component to $0. This way a user can still get a shipping component on their order (helpful for our label printing purposes) but it does not affect their order total.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Yes, I think it's very limiting to only have one shipping service available for the free shipping discount.

Of course you can go around this with Rules or by creating multiple discounts, but it's not the ideal solution (especially if the store is mainly maintained by someone who's not that good with Drupal). Some stores have so many shipping services that it would just feel stupid to create a discount for each of them to achieve the same result.

tophneal’s picture

tophneal CreditAttribution: tophneal commented
FileSize
Screen Shot 2017-03-28 at 4.37.49 PM.JPG277.18 KB

Have there been changes to the option Ryan mentioned in #4? I'm cannot get any of my shipping rates to be free, nor is the option to give a % off to any shipping service available for selection. Currently we have 7.x-1.x-a8 installed, is this option only available within dev? Screenshot attached.

EDIT: Correction, after further testing for an unrelated issue, I found that the 'Any' option does exist for '% off shipping,' however it is confusingly displayed as 'None.'

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented

There are a couple of issues I'd like to resolve before another release, please use -dev in the meantime. The issues off the top of my head are the compatibility issue.