ds_extras_entity_base_field_info() doesn't seem to be triggered anymore - boy this will be fun to figure out.

CommentFileSizeAuthor
#4 2560631.patch17.44 KBswentel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

swentel created an issue. See original summary.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

because automatic entity schema updates are turned off in update.php. I think we need to trigger a schema rebuild when enabling thw feature for thw first time.

There ahould be a change record for that.

swentel’s picture

swentel CreditAttribution: swentel commented

Ooh, that's why I saw nothing in update.php - funky - will search for the change record.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Active » Needs review
FileSize
2560631.patch17.44 KB

Moved to another module - also available in switch_view_mode branch.

Some overlap with #2588835: Reinstall ds_extra's fails regarding the setting.

swentel’s picture

swentel CreditAttribution: swentel commented

Note: didn't do our own storage - install works fine and adds the field, so I think we should be fine.
Maybe we should write a 'remove all data' thing, but let's wait how core will handle this in general.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Yeah if you just follow the "insert column on install" pattern, everything works fine.

The thing is that once you installed and enabled the module you can't uninstall it :p, because of datalose issues.
So this module probably will have some feature requests in the future for temporary disabling some features.

+    // @todo inject config

Is not needed anymore

// @todo entity bundle info does not store layout info anymore

I'm not sure this todo is needed either

We probably need a notice that people that have the setting already enabled should install the module. Or write an upgrade path that does that.
Once that is done I would commit this and let the tests run again.

  • aspilicious committed b9fa427 on 8.x-2.x authored by swentel 
    Issue #2560631 by swentel, aspilicious: ds_switch field not added...
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Fixed

Still working on the tests

Status: Fixed » Needs work

The last submitted patch, 4: 2560631.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Closed (fixed)