[D7] Algorithmia

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

FILE: /var/www/drupal-7-pareview/pareview_temp/algorithmia.admin.inc
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
70 | ERROR | [x] Whitespace found at end of line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 97ms; Memory: 5.5Mb

It may be a false positive like you said. You might want to try and remove the extra whitespace using a text editor and regular expression of some kind. Apart from that, it looks good

Manual Review

Individual user account
Yes: Follows guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements
Coding style & Drupal API usage
Yes: It follows code and API guidelines.

Hi sheldonkreger,
Nice work. Did not find any issue with your code. Though did not go through the functionality

Hi @sheldonkreger

manual review - just a few small issues

line 26 - I'd remove the comment , it doesnt help.

// This example comes from node.module.
if ($delta == 'algorithmia_recommender') {

adding the javascript to the block - can you use attached in the content array rather than embedding it as a string ?
something like

$block['content'] = array(
  '#markup' =>  _algorithmia_get_html(),
  '#attached' => array(

    ),
  ),
);

the file comment is wrong at the top of the install file.

/**
 * @file
 * Install, update and uninstall functions for the file_entity module.
 */

you've used a permission in your hook menu, but that isnt defined in a hook_permissions implementation

  'access arguments' => array('administer algorithmia'),

this means that you wouldnt be able to grant the permission to a non user 1 user.

other than those small issues, installs fine, works as advertised - I think if the permissions hook is added it can go to reviewed by the community

Im happy with these last changes that this can move to reviewed and tested by the community

I've granted you Git vetted user status.

@drumm: thanks for reviewing and helping out! For transparency I added you to the list of code review admins at https://groups.drupal.org/node/142454 . The usual template for applicants we use when we approve them from https://groups.drupal.org/node/184389#promote :

Thanks for your contribution, sheldonkreger!

drumm updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Thanks, and sorry I missed that. I only got involved because I've worked with sheldonkreger in the past (not currently), and saw https://www.drupal.org/news/help-test-drupalci#comment-10385551. Hopefully we can move forward on the project application process changes soon.