When you have the "Markup overrides" Extension enabled, and tick the "Remove the frontpage title" checkbox, that setting has no effect. The title of the frontpage node is still displayed, both in the HTML <head> and <body>.

CommentFileSizeAuthor
#5 adaptivetheme_2558779-5.patch839 bytesroball
#3 adaptivetheme_2558779-3.patch844 bytesroball
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

roball created an issue. See original summary.

roball’s picture

roball CreditAttribution: roball commented
Title: Markup override » "Remove the frontpage title" setting has no effect
Issue tags: -Remove the frontpage title
roball’s picture

roball CreditAttribution: roball commented
Version: 7.x-3.2 » 7.x-3.x-dev
Status: Active » Needs review
FileSize
adaptivetheme_2558779-3.patch844 bytes

The attached patch against the 7.x-3.x branch fixes this bug. $vars['title'] = ''; has to be replaced by $vars['node']->title = ''; to remove the title from the body. drupal_set_title(''); must be added to also remove it from the head.

Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented
Category: Bug report » Feature request

I think you are asking for a feature - basically you must have set a node as the front page, correct? I think thats fine and we probably should account for that option since its pretty common.

roball’s picture

roball CreditAttribution: roball commented
Title: "Remove the frontpage title" setting has no effect » "Remove the frontpage title" setting has no effect on some sub themes
FileSize
adaptivetheme_2558779-5.patch839 bytes

It turned out that removing the title from the body does work using the current code $vars['title'] = ''; for some AT sub themes, such as Mix and Match 7.x-2.1, while it does NOT work for other AT sub themes, such as AT Commerce 7.x-3.1. The latter needs the code $vars['node']->title = ''; instead. Thus, both lines of code should be included.

Attached is the updated patch that has both of these lines included.

roball’s picture

roball CreditAttribution: roball commented

Jeff, any change to get this in?

  • Jeff Burnz committed 7ae9118 on 7.x-3.x authored by roball 
    Issue #2558779 by roball: "Remove the frontpage title" setting has no...
Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented
Status: Needs review » Fixed
lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
CreditAttribution: lamp5 commented

So, after update to 7.x-3 i have got a warning
Warning: Creating default object from empty value in adaptivetheme_process_page() (line 91 z /sites/all/themes/adaptivetheme/at_core/inc/process.inc).

My frontpage is views page.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
CreditAttribution: lamp5 commented
Status: Fixed » Needs review
Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented
Status: Needs review » Active

replace line 91 with this:

        if (isset($vars['node'])) {
          $vars['node']->title = '';
        }

BTW, "Needs review" is for reviewing patches, if you set that I think theres a patch to review.

Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented
Status: Active » Fixed
Related issues: +#2765239: Warning: Creating default object from empty value in adaptivetheme_process_page()

Another issue was opened with the bug in #9, I've pushed the fix and released a new version, my apologies for the oversight.

roball’s picture

roball CreditAttribution: roball commented

Thank you for committing the fix!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.