Insert site content campaign autocomplete [#2558465]

Hello,
after updating core from 7.38 to 7.39, autocomplete in campaign insert content edit page not working anymore.
As related in this, I end up changing the line $form['entity_import']['entity_id']['#attribute']['id'] = $section . '-entity-import-entity-id'; with this one $form['entity_import']['entity_id']['#id'] = $section . '-entity-import-entity-id'; in the file modules/mailchimp_campaign/includes/mailchimp_campaign.admin.inc.
Everything works fine after this modification. Sorry I don't have the time to learn how to commit a patch now.
Regards,
Loïc

Comment	File	Size	Author
#2	mailchimp-site-content-campaign-autocomplete-2558465.patch	878 bytes	Greg Boggs
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

27 August 2015 at 09:49

aliod created an issue. See original summary.

Comment #2

Greg Boggs

he/him

English

Portland Oregon

CreditAttribution: Greg Boggs at ThinkShout commented 31 August 2015 at 22:55

Status:

Active

» Needs review

File	Size
mailchimp-site-content-campaign-autocomplete-2558465.patch	878 bytes

Thanks for reporting the issue Loïc. I've attached the above code as a patch to make review easier. This needs to be replicated, reviewed, and tested.

To create the patch I did the following:

git clone --branch 7.x-3.x http://git.drupal.org/project/mailchimp.git
cd mailchimp

Make the change.

git diff > mailchimp-site-content-campaign-autocomplete-2558465.patch

Comment #3

dmsmidt

he/him

Dutch

Amsterdam 🇳🇱🇪🇺

CreditAttribution: dmsmidt at Triquanta commented 9 September 2015 at 07:13

Status:

Needs review

» Reviewed & tested by the community

Works for me!

Comment #4

thejimbirch CreditAttribution: thejimbirch commented 2 October 2015 at 02:14

Works for me also.

Comment #5

2 October 2015 at 21:21

jami committed cc13c82 on authored by Greg Boggs

Issue #2558465 by Greg Boggs: Insert site content campaign autocomplete

Comment #6

jami CreditAttribution: jami at ThinkShout for Mailchimp commented 2 October 2015 at 21:24

Version:	7.x-3.4	» 7.x-3.x-dev
Status:	Reviewed & tested by the community	» Fixed

Works great. Thanks aliod, Greg, and other reviewers!

Comment #7

16 October 2015 at 21:24

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #8

mubiesam CreditAttribution: mubiesam commented 3 December 2015 at 11:10

Applied the patch, the autocomplete worked to show the
[mailchimp_campaign|entity_type=node|entity_id=5|view_mode=teaser]
but only the code, it will not display the content in the preview...

Any suggestion...
Thanks,

Comment #9

mubiesam CreditAttribution: mubiesam commented 3 December 2015 at 11:14

Status:

Closed (fixed)

» Active

Comment #10

14 April 2016 at 17:37

jami committed cc13c82 on 7.x-4.x authored by Greg Boggs

Issue #2558465 by Greg Boggs: Insert site content campaign autocomplete

Comment #11

14 April 2016 at 18:11

jami committed cc13c82 on 8.x-1.x authored by Greg Boggs

Issue #2558465 by Greg Boggs: Insert site content campaign autocomplete

Comment #12

mubiesam CreditAttribution: mubiesam commented 25 June 2016 at 02:47

Version:	7.x-3.x-dev	» 7.x-4.4
Component:	General	» User interface

Upgraded to 7.4 with library installed successfully, but still have the same problem in INSERT SITE CONTENT, only the following code shown, no actual content...

[mailchimp_campaign|entity_type=node|entity_id=5|view_mode=full]

Any suggestion...highly appreciated.