It would be great if we could specify custom elements in the HTML elements and attributes field since there are now modules like Entity Embed that provide their own element, <drupal-entity></drupal-entity>, and corresponding text filter to render the element in a specific way.

Right now, the regex in _wysiwyg_filter_xss_split() and wysiwyg_filter_parse_valid_elements() does not allow for the inclusion of "-" which is required in the custom element spec.

CommentFileSizeAuthor
#2 wysiwyg_filter-allow_custom_elements-2558239-2.patch1.28 KBbneil
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bneil created an issue. See original summary.

bneil’s picture

bneil CreditAttribution: bneil at The University of Iowa commented
Status: Active » Needs review
FileSize
wysiwyg_filter-allow_custom_elements-2558239-2.patch1.28 KB

Here's a patch that includes the hyphen in the regex.

bneil’s picture

bneil CreditAttribution: bneil at The University of Iowa commented
Title: Allow custom elements » Allow custom elements (including support for Entity Embed)
BarisW’s picture

BarisW CreditAttribution: BarisW at LimoenGroen commented
Status: Needs review » Reviewed & tested by the community

Thanks. This is really needed to use the Entity Embed module. Please commit.

BarisW’s picture

BarisW CreditAttribution: BarisW at LimoenGroen for gemeente Leidschendam-Voorburg commented

And applies cleanly to the current dev.

  • axel.rutz committed e311e6a on 7.x-1.x authored by bneil 
    Issue #2558239 by bneil: Allow custom elements (including support for...

axel.rutz credited axel.rutz.

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin at MachbarMacher commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.