I found a php notice when #theme is empty in _radix_process_input().

Notice: Undefined index: #theme em _radix_process_input() (linha 114 de /home/ubuntu/myproject/builds/20150825-152232/profiles/myproject/themes/radix/includes/form.inc).

CommentFileSizeAuthor
#9 radix-undefined-theme-2557385-9.patch583 bytesdsnopek
#2 radix-2557385-1.patch584 bytesgneutzling
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gneutzling created an issue. See original summary.

gneutzling’s picture

gneutzling CreditAttribution: gneutzling at Taller commented
FileSize
radix-2557385-1.patch584 bytes

Fix.

gneutzling’s picture

gneutzling CreditAttribution: gneutzling commented
Status: Active » Needs review
edmargomes’s picture

edmargomes CreditAttribution: edmargomes commented

Works for me!!

sebas5384’s picture

sebas5384 CreditAttribution: sebas5384 commented

hey @barraponto what do you think? could we merge this patch?

ndf’s picture

ndf CreditAttribution: ndf commented
Status: Needs review » Reviewed & tested by the community

Now tests same way for #type and #theme before adding the class form-control
Before it was only checking !empty for #type.

sw3b’s picture

sw3b CreditAttribution: sw3b commented

Work for me also ! Thanks

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Reviewed & tested by the community » Needs work

Actually, I don't think this patch is right. If $element['#theme'] is empty, then we don't need to make sure that it isn't on our blacklist. However, the current code in the patch will count not having the '#theme' key as equivalent to having a '#theme' that's on the blacklist. Instead, I think we should let any element that doesn't have '#theme' pass.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Needs work » Needs review
FileSize
radix-undefined-theme-2557385-9.patch583 bytes

Here's a patch that fixes the issue I raised in #8

michael_wojcik’s picture

michael_wojcik CreditAttribution: michael_wojcik commented

Thanks for the patch, @gneutzling and @dsnopek! Works great for me too!

gneutzling’s picture

gneutzling CreditAttribution: gneutzling commented
Status: Needs review » Reviewed & tested by the community
handrus’s picture

handrus CreditAttribution: handrus commented

+1! Works for me too!

  • dsnopek committed 4cfaea5 on 7.x-3.x authored by gneutzling 
    Issue #2557385 by gneutzling, dsnopek: Undefined index: #theme in...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Reviewed & tested by the community » Fixed

Thanks, everyone, for the testing! Committed. :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.